Peter M. Groen / FlashMQ

Commit 5856733cc91c10ab19e90fdaeb81c5c486c8952a

Authored by Wiebe Cazemier
1 parent 295cf8ee

Change sessions copy from list to vector when saving 

When there are many sessions, the copying action can actually take some
time, and memory. A vector is faster and uses (a little) less memory.

This is a theoretical fix, without benchmarks to support it.
Inline Side-by-side
Showing 3 changed files with 4 additions and 3 deletions
sessionsandsubscriptionsdb.cpp
  View file @5856733
... ... @@ -183,7 +183,7 @@ void SessionsAndSubscriptionsDB::writeRowHeader()
183 183  
184 184 }
185 185  
186   -void SessionsAndSubscriptionsDB::saveData(const std::list<std::unique_ptr<Session>> &sessions, const std::unordered_map<std::string, std::list<SubscriptionForSerializing>> &subscriptions)
  186 +void SessionsAndSubscriptionsDB::saveData(const std::vector<std::unique_ptr<Session>> &sessions, const std::unordered_map<std::string, std::list<SubscriptionForSerializing>> &subscriptions)
187 187 {
188 188 if (!f)
189 189 return;
... ...
sessionsandsubscriptionsdb.h
  View file @5856733
... ... @@ -64,7 +64,7 @@ public:
64 64 void openWrite();
65 65 void openRead();
66 66  
67   - void saveData(const std::list<std::unique_ptr<Session>> &sessions, const std::unordered_map<std::string, std::list<SubscriptionForSerializing>> &subscriptions);
  67 + void saveData(const std::vector<std::unique_ptr<Session>> &sessions, const std::unordered_map<std::string, std::list<SubscriptionForSerializing>> &subscriptions);
68 68 SessionsAndSubscriptionsResult readData();
69 69 };
70 70  
... ...
subscriptionstore.cpp
  View file @5856733
... ... @@ -639,7 +639,8 @@ void SubscriptionStore::saveSessionsAndSubscriptions(const std::string &amp;filePath
639 639  
640 640 // First copy the sessions...
641 641  
642   - std::list<std::unique_ptr<Session>> sessionCopies;
  642 + std::vector<std::unique_ptr<Session>> sessionCopies;
  643 + sessionCopies.reserve(sessionsByIdConst.size());
643 644  
644 645 for (const auto &pair : sessionsByIdConst)
645 646 {
... ...