Expire retained messages

Wiebe Cazemier
1 parent 17c71d06
Showing 1 changed file with 7 additions and 3 deletions
subscriptionstore.cpp
@@ -479,10 +479,14 @@ void SubscriptionStore::giveClientRetainedMessagesRecursively(std::vector&lt;std::s
 {
     if (cur_subtopic_it == end)
     {
-        for(const RetainedMessage &rm : this_node->retainedMessages)
+        auto pos = this_node->retainedMessages.begin();
+        while (pos != this_node->retainedMessages.end())
         {
-            // TODO: hmm, const stuff forces me/it to make copy
-            packetList.emplace_front(rm.publish);
+            auto cur = pos++;
+            if (cur->publish.hasExpired())
+                this_node->retainedMessages.erase(cur);
+            else
+                packetList.emplace_front(cur->publish); // TODO: hmm, const stuff forces me/it to make copy
         }
         if (poundMode)
         {