Better support / fixes for clients with fd 0

It caused really funky behavior. When a destructed client closed fd 0, eventfd() would give 0 back as fd. This would then later give errors.

Better support / fixes for clients with fd 0
It caused really funky behavior. When a destructed client closed fd 0, eventfd() would give 0 back as fd. This would then later give errors.
Wiebe Cazemier
1 parent 5614ee5c
Showing 2 changed files with 34 additions and 7 deletions
FlashMQTests/tst_maintests.cpp
client.cpp
@@ -62,10 +62,10 @@ public:
     ~MainTests();
 private slots:
-    void init();
-    void cleanup();
+    void init(); // will be called before each test function is executed
+    void cleanup(); // will be called after every test function.
-    void cleanupTestCase();
+    void cleanupTestCase(); // will be called after the last test function was executed.
     void test_circbuf();
     void test_circbuf_unwrapped_doubling();
@@ -1091,6 +1091,20 @@ void MainTests::testSavingSessions()
     }
 }
-QTEST_GUILESS_MAIN(MainTests)
+int main(int argc, char *argv[])
+{
+    QCoreApplication app(argc, argv);
+    app.setAttribute(Qt::AA_Use96Dpi, true);
+    MainTests tc;
+
+    QTEST_SET_MAIN_SOURCE_PATH;
+
+    // You can more easily debug tests (in case of crashes) by running directly, instead of called as slots by Qt.
+    //tc.init();
+    //tc.testCopyPacket();
+    //return 0;
+
+    return QTest::qExec(&tc, argc, argv);
+}
 #include "tst_maintests.moc"
@@ -66,9 +66,12 @@ Client::~Client()
         disconnectReason = "not specified";
     logger->logf(LOG_NOTICE, "Removing client '%s'. Reason(s): %s", repr().c_str(), disconnectReason.c_str());
-    if (epoll_ctl(threadData->epollfd, EPOLL_CTL_DEL, fd, NULL) != 0)
-        logger->logf(LOG_ERR, "Removing fd %d of client '%s' from epoll produced error: %s", fd, repr().c_str(), strerror(errno));
-    close(fd);
+    if (fd > 0) // this check is essentially for testing, when working with a dummy fd.
+    {
+        if (epoll_ctl(threadData->epollfd, EPOLL_CTL_DEL, fd, NULL) != 0)
+            logger->logf(LOG_ERR, "Removing fd %d of client '%s' from epoll produced error: %s", fd, repr().c_str(), strerror(errno));
+        close(fd);
+    }
     // MQTT-3.1.2-6
     if (cleanSession)
@@ -338,6 +341,11 @@ void Client::setReadyForWriting(bool val)
         return;
 #endif
+#ifdef TESTING
+    if (fd == 0)
+        return;
+#endif
+
     if (disconnecting)
         return;
@@ -364,6 +372,11 @@ void Client::setReadyForReading(bool val)
         return;
 #endif
+#ifdef TESTING
+    if (fd == 0)
+        return;
+#endif
+
     if (disconnecting)
         return;