Removing some appveyor warnings

Henry Fredrick Schreiner · Henry Schreiner
1 parent 9359f642
Showing 3 changed files with 10 additions and 9 deletions
.appveyor.yml
include/CLI/App.hpp
include/CLI/Option.hpp
@@ -9,11 +9,11 @@ install:
 build_script:
   - mkdir build
   - cd build
-  - cmake .. -DCLI_SINGLE_FILE_TESTS=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_GENERATOR="Visual Studio 14 2015"
+  - cmake .. -DCLI_SINGLE_FILE_TESTS=ON -DCMAKE_BUILD_TYPE=Debug -DCMAKE_GENERATOR="Visual Studio 14 2015"
   - cmake --build .
 test_script:
-  - ctest --output-on-failure -C RelWithDebInfo
+  - ctest --output-on-failure -C Debug
 notifications:
   - provider: Webhook
@@ -910,9 +910,9 @@ class App {
                 subcmd_groups_seen.insert(group_key);
                 out << std::endl << com->get_group() << ":" << std::endl;
-                for(const App_p &com : subcommands_)
-                    if(detail::to_lower(com->get_group()) == group_key)
-                        detail::format_help(out, com->get_name(), com->description_, wid);
+                for(const App_p &new_com : subcommands_)
+                    if(detail::to_lower(new_com->get_group()) == group_key)
+                        detail::format_help(out, new_com->get_name(), new_com->description_, wid);
             }
         }
@@ -408,17 +408,18 @@ class Option : public OptionBase&lt;Option&gt; {
     /// Process the callback
     void run_callback() const {
-        bool result;
+        bool local_result;
         // If take_last, only operate on the final item
         if(last_) {
             results_t partial_result = {results_.back()};
-            result = !callback_(partial_result);
+            local_result = !callback_(partial_result);
         } else {
-            result = !callback_(results_);
+            local_result = !callback_(results_);
         }
-        if(result)
+        if(local_result)
             throw ConversionError(get_name() + "=" + detail::join(results_));
+
         if(!validators_.empty()) {
             for(const std::string &result : results_)
                 for(const std::function<bool(std::string)> &vali : validators_)