Peter M. Groen / CLI11

Commit 2bea3983c0f9d30ee5ceacced230d2105d716989

Authored by Kannan
Committed by Henry Schreiner
1 parent a687eb95

Return empty string in Option::get_name() for hidden options (#333) 

* Return empty string in Option::get_name() for hidden options

Fixes https://github.com/CLIUtils/CLI11/issues/332

* Remove to_lower() call

* Formatting

* Fix THelp.Hidden
Inline Side-by-side
Showing 2 changed files with 3 additions and 1 deletions
include/CLI/Option.hpp
  View file @2bea398
... ... @@ -652,6 +652,8 @@ class Option : public OptionBase<Option> {
652 652 std::string get_name(bool positional = false, //<[input] Show the positional name
653 653 bool all_options = false //<[input] Show every option
654 654 ) const {
  655 + if(get_group().empty())
  656 + return {}; // Hidden
655 657  
656 658 if(all_options) {
657 659  
... ...
tests/HelpTest.cpp
  View file @2bea398
... ... @@ -92,7 +92,7 @@ TEST(THelp, Hidden) {
92 92 EXPECT_THAT(help, HasSubstr("My prog"));
93 93 EXPECT_THAT(help, HasSubstr("-h,--help"));
94 94 EXPECT_THAT(help, HasSubstr("Options:"));
95   - EXPECT_THAT(help, HasSubstr("[something]"));
  95 + EXPECT_THAT(help, Not(HasSubstr("[something]")));
96 96 EXPECT_THAT(help, Not(HasSubstr("something ")));
97 97 EXPECT_THAT(help, Not(HasSubstr("another")));
98 98 }
... ...