Commit 225492f6f2ed5fee23195326c3b1511e480d1553
Committed by
Henry Schreiner
Henry Schreiner
1 parent
a323d7b4
Add virtual destructor to Config class
Clang++/LLVM 6.0 complains about this from warning -Wdelete-non-virtual-dtor which is included when using -Wall. Both App and FormatterBase already have virtual destructors, so this was probably just accidentally left out. This is also a C++ best practice; I have drawn some guidelines from here: http://www.gotw.ca/publications/mill18.htm
Showing
1 changed file
with
3 additions
and
0 deletions
include/CLI/ConfigFwd.hpp
| @@ -78,6 +78,9 @@ class Config { | @@ -78,6 +78,9 @@ class Config { | ||
| 78 | 78 | ||
| 79 | return from_config(input); | 79 | return from_config(input); |
| 80 | } | 80 | } |
| 81 | + | ||
| 82 | + /// virtual destructor | ||
| 83 | + virtual ~Config() = default; | ||
| 81 | }; | 84 | }; |
| 82 | 85 | ||
| 83 | /// This converter works with INI files | 86 | /// This converter works with INI files |