Nicer error messages

Henry Fredrick Schreiner · Henry Schreiner
1 parent a958ffec
Showing 3 changed files with 5 additions and 5 deletions
include/CLI/App.hpp
include/CLI/Ini.hpp
include/CLI/Option.hpp
@@ -1357,7 +1357,7 @@ class App {
         std::string name;
         std::string rest;
         if(!detail::split_short(current, name, rest))
-            throw HorribleError("Short");
+            throw HorribleError("Short parsed but missing! You should not see this");
         auto op_ptr = std::find_if(
             std::begin(options_), std::end(options_), [name](const Option_p &opt) { return opt->check_sname(name); });
@@ -1437,7 +1437,7 @@ class App {
         std::string name;
         std::string value;
         if(!detail::split_long(current, name, value))
-            throw HorribleError("Long:" + args.back());
+            throw HorribleError("Long parsed but missing (you should not see this):" + args.back());
         auto op_ptr = std::find_if(
             std::begin(options_), std::end(options_), [name](const Option_p &v) { return v->check_lname(name); });
@@ -106,7 +106,7 @@ inline std::vector&lt;ini_ret_t&gt; parse_ini(const std::string &amp;name) {
     std::ifstream input{name};
     if(!input.good())
-        throw FileError(name);
+        throw FileError(name + " was not readable (missing?)");
     return parse_ini(input);
 }
@@ -428,13 +428,13 @@ class Option : public OptionBase&lt;Option&gt; {
         }
         if(local_result)
-            throw ConversionError(get_name() + "=" + detail::join(results_));
+            throw ConversionError("Could not convert: " + get_name() + "=" + detail::join(results_));
         if(!validators_.empty()) {
             for(const std::string &result : results_)
                 for(const std::function<bool(std::string)> &vali : validators_)
                     if(!vali(result))
-                        throw ValidationError(get_name() + "=" + result);
+                        throw ValidationError("Failed validation: " + get_name() + "=" + result);
         }
     }