Fix catch by value

Henry Fredrick Schreiner
1 parent 1ee22ec9
Showing 2 changed files with 5 additions and 5 deletions
.clang-tidy
include/CLI/TypeTools.hpp
 #Checks: '*,-clang-analyzer-alpha.*'
 #Checks: '-*,google-readability-casting,llvm-namespace-comment,performance-unnecessary-value-param,llvm-include-order,misc-throw-by-value-catch-by-reference,readability-container-size-empty,google-runtime-references,modernize*'
-Checks: '-*,llvm-namespace-comment,llvm-include-order,readability-container-size-empty'
+Checks: '-*,llvm-namespace-comment,llvm-include-order,readability-container-size-empty,misc-throw-by-value-catch-by-reference'
 HeaderFilterRegex: '.*hpp'
 CheckOptions:
 - key:             readability-braces-around-statements.ShortStatementLines
@@ -104,9 +104,9 @@ namespace detail {
         try{
             output = (T) std::stoll(input);
             return true;
-        } catch (std::invalid_argument) {
+        } catch (const std::invalid_argument&) {
             return false;
-        } catch (std::out_of_range) {
+        } catch (const std::out_of_range&) {
             return false;
         }
     }
@@ -117,9 +117,9 @@ namespace detail {
         try{
             output = (T) std::stold(input);
             return true;
-        } catch (std::invalid_argument) {
+        } catch (const std::invalid_argument&) {
             return false;
-        } catch (std::out_of_range) {
+        } catch (const std::out_of_range&) {
             return false;
         }
     }