• (patrepl and cleanpatch are my own utilities)
    
    patrepl s/PointerHolder/std::shared_ptr/g {include,libqpdf}/qpdf/*.hh
    patrepl s/PointerHolder/std::shared_ptr/g libqpdf/*.cc
    patrepl s/make_pointer_holder/std::make_shared/g libqpdf/*.cc
    patrepl s/make_array_pointer_holder/QUtil::make_shared_array/g libqpdf/*.cc
    patrepl s,qpdf/std::shared_ptr,qpdf/PointerHolder, **/*.cc **/*.hh
    git restore include/qpdf/PointerHolder.hh
    cleanpatch
    ./format-code
    Jay Berkenbilt authored
     
    Browse File »


  • This comment expands all tabs using an 8-character tab-width. You
    should ignore this commit when using git blame or use git blame -w.
    
    In the early days, I used to use tabs where possible for indentation,
    since emacs did this automatically. In recent years, I have switched
    to only using spaces, which means qpdf source code has been a mixture
    of spaces and tabs. I have avoided cleaning this up because of not
    wanting gratuitous whitespaces change to cloud the output of git
    blame, but I changed my mind after discussing with users who view qpdf
    source code in editors/IDEs that have other tab widths by default and
    in light of the fact that I am planning to start applying automatic
    code formatting soon.
    Jay Berkenbilt authored
     
    Browse File »















  • Move object parsing code from QPDF to QPDFObjectHandle and
    parameterize the parts of it that are specific to a QPDF object.
    Provide a version that can't handle indirect objects and that can be
    called on an arbitrary string.
    
    A side effect of this change is that the offset used when reporting
    invalid stream length has changed, but since the new value seems like
    a better value than the old one, the test suite has been updated
    rather than making the code backward compatible.  This only effects
    the offset reported for invalid streams that lack /Length or have an
    invalid /Length key.
    
    Updated some test code and exmaples to use QPDFObjectHandle::parse.
    
    Supporting changes include adding a BufferInputSource constructor that
    takes a string.
    Jay Berkenbilt authored
     
    Browse File »

  • Breaking API change: length parameter has disappeared from the
    StreamDataProvider version of QPDFObjectHandle::replaceStreamData
    since it is no longer necessary to compute it in advance.  This
    breaking change is justified by the fact that removing the length
    parameter provides the caller an opportunity to simplify the calling
    code.
    Jay Berkenbilt authored
     
    Browse File »