• Where not possible, use "auto" to get the iterator type.
    
    Editorial note: I have avoid this change for a long time because of
    not wanting to make gratuitous changes to version history, which can
    obscure when certain changes were made, but with having recently
    touched every single file to apply automatic code formatting and with
    making several broad changes to the API, I decided it was time to take
    the plunge and get rid of the older (pre-C++11) verbose iterator
    syntax. The new code is just easier to read and understand, and in
    many cases, it will be more effecient as fewer temporary copies are
    being made.
    
    m-holger, if you're reading, you can see that I've finally come
    around. :-)
    Jay Berkenbilt authored
     
    Browse File »
  • Change .clang-format and commit automated changes from a fresh run of
    format-code
    Jay Berkenbilt authored
     
    Browse File »


  • Increase to POINTERHOLDER_TRANSITION=3
    
    patrepl s/PointerHolder/std::shared_ptr/g **/*.cc **/*.hh
    patrepl s/make_pointer_holder/std::make_shared/g **/*.cc
    patrepl s/make_array_pointer_holder/QUtil::make_shared_array/g **/*.cc
    patrepl s,qpdf/std::shared_ptr,qpdf/PointerHolder, **/*.cc **/*.hh
    git restore include/qpdf/PointerHolder.hh
    git restore libtests/pointer_holder.cc
    cleanpatch
    ./format-code
    Jay Berkenbilt authored
     
    Browse File »



  • This comment expands all tabs using an 8-character tab-width. You
    should ignore this commit when using git blame or use git blame -w.
    
    In the early days, I used to use tabs where possible for indentation,
    since emacs did this automatically. In recent years, I have switched
    to only using spaces, which means qpdf source code has been a mixture
    of spaces and tabs. I have avoided cleaning this up because of not
    wanting gratuitous whitespaces change to cloud the output of git
    blame, but I changed my mind after discussing with users who view qpdf
    source code in editors/IDEs that have other tab widths by default and
    in light of the fact that I am planning to start applying automatic
    code formatting soon.
    Jay Berkenbilt authored
     
    Browse File »








  • This makes all integer type conversions that have potential data loss
    explicit with calls that do range checks and raise an exception. After
    this commit, qpdf builds with no warnings when -Wsign-conversion
    -Wconversion is used with gcc or clang or when -W3 -Wd4800 is used
    with MSVC. This significantly reduces the likelihood of potential
    crashes from bogus integer values.
    
    There are some parts of the code that take int when they should take
    size_t or an offset. Such places would make qpdf not support files
    with more than 2^31 of something that usually wouldn't be so large. In
    the event that such a file shows up and is valid, at least qpdf would
    raise an error in the right spot so the issue could be legitimately
    addressed rather than failing in some weird way because of a silent
    overflow condition.
    Jay Berkenbilt authored
     
    Browse File »




  • If NO_GET_ENVIRONMENT is #defined at compile time on Windows, do not
    call GetEnvironmentVariable.  QUtil::get_env will always return
    false.  This option is not available through configure.  This was
    added to support a specific user's requirements to avoid calling
    GetEnvironmentVariable from the Windows API.  Nothing in qpdf outside
    the test coverage system in qtest relies on QUtil::get_env.
    Jay Berkenbilt authored
     
    Browse File »



  • Breaking API change: length parameter has disappeared from the
    StreamDataProvider version of QPDFObjectHandle::replaceStreamData
    since it is no longer necessary to compute it in advance.  This
    breaking change is justified by the fact that removing the length
    parameter provides the caller an opportunity to simplify the calling
    code.
    Jay Berkenbilt authored
     
    Browse File »