• This makes all integer type conversions that have potential data loss
    explicit with calls that do range checks and raise an exception. After
    this commit, qpdf builds with no warnings when -Wsign-conversion
    -Wconversion is used with gcc or clang or when -W3 -Wd4800 is used
    with MSVC. This significantly reduces the likelihood of potential
    crashes from bogus integer values.
    
    There are some parts of the code that take int when they should take
    size_t or an offset. Such places would make qpdf not support files
    with more than 2^31 of something that usually wouldn't be so large. In
    the event that such a file shows up and is valid, at least qpdf would
    raise an error in the right spot so the issue could be legitimately
    addressed rather than failing in some weird way because of a silent
    overflow condition.
    Jay Berkenbilt authored
     
    Browse File »
  • Change from unsigned long to int since we pass enumerated type values
    to this field.
    Jay Berkenbilt authored
     
    Browse File »

  • On read, ignore /DecodeParms when empty list; on write, delete it.
    Some files have been found that include an empty list for
    /DecodeParms, but this is not technically compliant with the spec, and
    the only sensible interpretation is to treat it as if there are no
    decode parameters.
    Jay Berkenbilt authored
     
    Browse File »















  • Move object parsing code from QPDF to QPDFObjectHandle and
    parameterize the parts of it that are specific to a QPDF object.
    Provide a version that can't handle indirect objects and that can be
    called on an arbitrary string.
    
    A side effect of this change is that the offset used when reporting
    invalid stream length has changed, but since the new value seems like
    a better value than the old one, the test suite has been updated
    rather than making the code backward compatible.  This only effects
    the offset reported for invalid streams that lack /Length or have an
    invalid /Length key.
    
    Updated some test code and exmaples to use QPDFObjectHandle::parse.
    
    Supporting changes include adding a BufferInputSource constructor that
    takes a string.
    Jay Berkenbilt authored
     
    Browse File »

  • Breaking API change: length parameter has disappeared from the
    StreamDataProvider version of QPDFObjectHandle::replaceStreamData
    since it is no longer necessary to compute it in advance.  This
    breaking change is justified by the fact that removing the length
    parameter provides the caller an opportunity to simplify the calling
    code.
    Jay Berkenbilt authored
     
    Browse File »