-
* Define POINTERHOLDER_TRANSITION * Make sure we are getting the intended version of qpdf
-
It might be worth enabling code scanning at GitHub, which is a superset of lgtm.
-
Over time, qpdf's grade has dropped on lgtm, but they are not transparent about how grades are assigned. Fixing current alerts, in my opinion, reduces clarity and maintainability of the code in the name of performance in non-critical sections of code. Some analysis by m-holger suggests that fixing some of the current alerts actually degrades performance (slightly) while fixing others results in insignificant improvements. The quality of qpdf can be measured in other ways, such as its extensive test suite, documentation, and long track record of reliably manipulating PDFs with high performance, few bugs, and few external dependencies. The lgtm rating is a distraction at best.
-
Also add stubs for top-level QPDF methods (createFromJSON, updateFromJSON)
-
Prevent my future self or other contributors from using assert in tests and then having that assert not do anything because of the NDEBUG macro.
-
This enables RTTI so we can use dynamic_cast on them across the shared object boundary.
-
I'm not sure why this is needed now and wasn't needed before since the cmake changes have been in main for a while and there don't appear to be recent changes to the appimage build tools. This change adds to lib directory to LD_LIBRARY_PATH so the appimage tools' ldd check will pass. This is an appropriate change since the directory that is added will be in the standard load path when installed.
-
Files are copied into the build area rather than left in the source tree, and the test suite looks for them there. Also remove special case around counting files in the qpdf corpus.
-
We have been keeping main's version at the last released version, but starting now, main's version will always be whatever it would be if a release were cut from the tip of main.
-
Remove comparison of qpdf CLI version with library. With almost all the functionality moving into the library, this check is no longer meaningful.