• Prior to the cmake conversion, several private classes had methods
    that were exported into the shared library so they could be tested
    with libtests. With cmake, we build libtests using an object library,
    so this is no longer necessary. The methods that are disappearing from
    the ABI were never exposed through public headers, so no code should
    be using them. Removal had to wait until the window for ABI-breaking
    changes was open.
    Jay Berkenbilt authored
     
    Browse File »

  • This makes all integer type conversions that have potential data loss
    explicit with calls that do range checks and raise an exception. After
    this commit, qpdf builds with no warnings when -Wsign-conversion
    -Wconversion is used with gcc or clang or when -W3 -Wd4800 is used
    with MSVC. This significantly reduces the likelihood of potential
    crashes from bogus integer values.
    
    There are some parts of the code that take int when they should take
    size_t or an offset. Such places would make qpdf not support files
    with more than 2^31 of something that usually wouldn't be so large. In
    the event that such a file shows up and is valid, at least qpdf would
    raise an error in the right spot so the issue could be legitimately
    addressed rather than failing in some weird way because of a silent
    overflow condition.
    Jay Berkenbilt authored
     
    Browse File »