• They have to be ot_* rather than qpdf_ot_* for compatibility.
    
    * Different enumerated types are not assignment-compatible in C++, at
      least with strict compiler settings
    * While you can do `constexpr ot_xyz = ::qpdf_ot_xyz` in QPDFObject.hh to
      make QPDFObject::ot_xyz work, QPDFObject::object_type_e::ot_xyz will
      only work if the enumerated type names are the same.
    Jay Berkenbilt authored
     
    Browse File »













  • This fixes cases of warning C4800 from msvc
    Jay Berkenbilt authored
     
    Browse File »
  • This makes all integer type conversions that have potential data loss
    explicit with calls that do range checks and raise an exception. After
    this commit, qpdf builds with no warnings when -Wsign-conversion
    -Wconversion is used with gcc or clang or when -W3 -Wd4800 is used
    with MSVC. This significantly reduces the likelihood of potential
    crashes from bogus integer values.
    
    There are some parts of the code that take int when they should take
    size_t or an offset. Such places would make qpdf not support files
    with more than 2^31 of something that usually wouldn't be so large. In
    the event that such a file shows up and is valid, at least qpdf would
    raise an error in the right spot so the issue could be legitimately
    addressed rather than failing in some weird way because of a silent
    overflow condition.
    Jay Berkenbilt authored
     
    Browse File »





  • For non-encrypted files, determinstic ID generation uses file contents
    instead of timestamp and file name. At a small runtime cost, this
    enables generation of the same /ID if the same inputs are converted in
    the same way multiple times.
    Jay Berkenbilt authored
     
    Browse File »