You need to sign in before continuing.








  • This comment expands all tabs using an 8-character tab-width. You
    should ignore this commit when using git blame or use git blame -w.
    
    In the early days, I used to use tabs where possible for indentation,
    since emacs did this automatically. In recent years, I have switched
    to only using spaces, which means qpdf source code has been a mixture
    of spaces and tabs. I have avoided cleaning this up because of not
    wanting gratuitous whitespaces change to cloud the output of git
    blame, but I changed my mind after discussing with users who view qpdf
    source code in editors/IDEs that have other tab widths by default and
    in light of the fact that I am planning to start applying automatic
    code formatting soon.
    Jay Berkenbilt authored
     
    Browse File »



  • This makes all integer type conversions that have potential data loss
    explicit with calls that do range checks and raise an exception. After
    this commit, qpdf builds with no warnings when -Wsign-conversion
    -Wconversion is used with gcc or clang or when -W3 -Wd4800 is used
    with MSVC. This significantly reduces the likelihood of potential
    crashes from bogus integer values.
    
    There are some parts of the code that take int when they should take
    size_t or an offset. Such places would make qpdf not support files
    with more than 2^31 of something that usually wouldn't be so large. In
    the event that such a file shows up and is valid, at least qpdf would
    raise an error in the right spot so the issue could be legitimately
    addressed rather than failing in some weird way because of a silent
    overflow condition.
    Jay Berkenbilt authored
     
    Browse File »