• Prior to the cmake conversion, several private classes had methods
    that were exported into the shared library so they could be tested
    with libtests. With cmake, we build libtests using an object library,
    so this is no longer necessary. The methods that are disappearing from
    the ABI were never exposed through public headers, so no code should
    be using them. Removal had to wait until the window for ABI-breaking
    changes was open.
    Jay Berkenbilt authored
     
    Browse Dir »
  • Increase to POINTERHOLDER_TRANSITION=4
    Jay Berkenbilt authored
     
    Browse Dir »
  • (patrepl and cleanpatch are my own utilities)
    
    patrepl s/PointerHolder/std::shared_ptr/g {include,libqpdf}/qpdf/*.hh
    patrepl s/PointerHolder/std::shared_ptr/g libqpdf/*.cc
    patrepl s/make_pointer_holder/std::make_shared/g libqpdf/*.cc
    patrepl s/make_array_pointer_holder/QUtil::make_shared_array/g libqpdf/*.cc
    patrepl s,qpdf/std::shared_ptr,qpdf/PointerHolder, **/*.cc **/*.hh
    git restore include/qpdf/PointerHolder.hh
    cleanpatch
    ./format-code
    Jay Berkenbilt authored
     
    Browse Dir »





  • This comment expands all tabs using an 8-character tab-width. You
    should ignore this commit when using git blame or use git blame -w.
    
    In the early days, I used to use tabs where possible for indentation,
    since emacs did this automatically. In recent years, I have switched
    to only using spaces, which means qpdf source code has been a mixture
    of spaces and tabs. I have avoided cleaning this up because of not
    wanting gratuitous whitespaces change to cloud the output of git
    blame, but I changed my mind after discussing with users who view qpdf
    source code in editors/IDEs that have other tab widths by default and
    in light of the fact that I am planning to start applying automatic
    code formatting soon.
    Jay Berkenbilt authored
     
    Browse Dir »