-
This is a performance fix. The output is unchanged. Fixes #28.
-
Add a method to get the current random data provider, and document and test the method for resetting it.
-
Also remove some trivial, non-functional code.
-
Add new RandomDataProvider object and implement existing random number generation in terms of that. This enables end users to supply their own random data providers.
-
Fixes #27.
-
If NO_GET_ENVIRONMENT is #defined at compile time on Windows, do not call GetEnvironmentVariable. QUtil::get_env will always return false. This option is not available through configure. This was added to support a specific user's requirements to avoid calling GetEnvironmentVariable from the Windows API. Nothing in qpdf outside the test coverage system in qtest relies on QUtil::get_env.
-
In compare image tests, use the gs device tiff24nc instead of tiff12nc since the 4 bit per sample images created by tiff12nc could sometimes trigger a bug in tiffcmp. Fixes #20.
-
Also accept -accessibility=n with 256 bit keys even though it will be ignored.
-
For std::string and std::vector, replace operator[] with at. This was done using an automated process. See README.hardening for details.
-
If not available, give an error. The user may also configure qpdf to use an insecure random number generator.
-
Ideally, the library should never call assert outside of test code, but it does in several places. For some cases where the assertion might conceivably fail because of a problem with the input data, replace assertions with exceptions so that they can be trapped by the calling application. This commit surely misses some cases and replaced some cases unnecessarily, but it should still be an improvement.
-
In places where std::vector<T>(size_t) was used, either validate that the size parameter is sane or refactor code to avoid the need to pre-allocate the vector.
-
The /W array was not sanitized, possibly causing an integer overflow in a multiplication. An analysis of the code suggests that there were no possible exploits based on this since the problems were in checking expected values but bounds checks were performed on actual values.
-
The faulty code was only used during explicit checks of linearization data. Those checks are not part of normal reading or writing of PDF files.
-
Better sanity check inputs to bit stream reader
-
4.2.0 was binary incompatible in spite of there being no deletions or changes to any public methods. As such, we have to bump the ABI and are fixing some API breakage while we're at it. Previous 4.3.0 target is now 5.1.0.