• Jay Berkenbilt authored
     
    Browse Dir »
  • This makes all integer type conversions that have potential data loss
    explicit with calls that do range checks and raise an exception. After
    this commit, qpdf builds with no warnings when -Wsign-conversion
    -Wconversion is used with gcc or clang or when -W3 -Wd4800 is used
    with MSVC. This significantly reduces the likelihood of potential
    crashes from bogus integer values.
    
    There are some parts of the code that take int when they should take
    size_t or an offset. Such places would make qpdf not support files
    with more than 2^31 of something that usually wouldn't be so large. In
    the event that such a file shows up and is valid, at least qpdf would
    raise an error in the right spot so the issue could be legitimately
    addressed rather than failing in some weird way because of a silent
    overflow condition.
    Jay Berkenbilt authored
     
    Browse Dir »

  • * [bcc32 Error] QPDF.cc(375): E2268 Call to undefined function 'atof'
      Full parser context
        QPDF.cc(358): parsing: void QPDF::parse(const char *)
    
    * [bcc32 Error] QPDFTokenizer.cc(183): E2268 Call to undefined function 'strtol'
      Full parser context
        QPDFTokenizer.cc(163): parsing: void QPDFTokenizer::resolveLiteral()
    
    * [bcc32 Error] pdf-split-pages.cc(52): E2268 Call to undefined function 'exit'
      Full parser context
        pdf-split-pages.cc(50): parsing: void usage()
    
    * PR #295: Including "cstdlib" should be replaced with "stdlib.h" to be more consistent. At the same time I changed the order of the surrounding includes to reflect alphabetical order, because at some files this already have been the case.
    Thorsten Schöning authored
     
    Browse Dir »