Check for warnings in files used by --pages

Jay Berkenbilt
1 parent dedf9a06
Showing 4 changed files with 13 additions and 1 deletions
ChangeLog
libqpdf/QPDFJob.cc
qpdf/qtest/page-errors.test
qpdf/qtest/qpdf/page-missing-mediabox.out
+2023-09-03  Jay Berkenbilt  <ejb@ql.org>
+
+        * Bug fix: with --pages, if one of the external files had warnings
+        but the main file did not, the warning was previously not taken
+        into consideration when determining the exit status.
+
 2023-09-02  Jay Berkenbilt  <ejb@ql.org>
         * Bug fix from M. Holger: allow fix-qdf to read from pipe. Fixes #1010.
@@ -2561,6 +2561,11 @@ QPDFJob::handlePageSpecs(QPDF&amp; pdf, std::vector&lt;std::unique_ptr&lt;QPDF&gt;&gt;&amp; page_hea
             }
         }
     }
+    for (auto const& p: page_spec_qpdfs) {
+        if (!p.second->getWarnings().empty()) {
+            m->warnings = true;
+        }
+    }
 }
 void
@@ -22,7 +22,7 @@ $td-&gt;runtest(&quot;handle page no with contents&quot;,
              $td->NORMALIZE_NEWLINES);
 $td->runtest("handle page with missing MediaBox",
              {$td->COMMAND => "qpdf --static-id --empty --pages page-no-content.pdf -- out.pdf"},
-             {$td->FILE => "page-missing-mediabox.out", $td->EXIT_STATUS => 0},
+             {$td->FILE => "page-missing-mediabox.out", $td->EXIT_STATUS => 3},
              $td->NORMALIZE_NEWLINES);
 $td->runtest("check output",
              {$td->FILE => "out.pdf"},
 WARNING: page-no-content.pdf, object 4 0 at offset 288: kid 1 (from 0) MediaBox is undefined; setting to letter / ANSI A
+qpdf: operation succeeded with warnings; resulting file may have some problems