Expose QPDFArgParser::usage

Jay Berkenbilt
1 parent 8dcf6da2
Showing 2 changed files with 7 additions and 10 deletions
include/qpdf/QPDFArgParser.hh
libqpdf/QPDFJob_argv.cc
@@ -150,6 +150,12 @@ class QPDFArgParser
     QPDF_DLL
     void insertCompletion(std::string const&);
  
+    // Throw a Usage exception with the given message. In completion
+    // mode, this just exits to prevent errors from partial commands
+    // or other error messages from messing up completion.
+    QPDF_DLL
+    void usage(std::string const& message);
+
   private:
     struct OptionEntry
     {
@@ -174,7 +180,6 @@ class QPDFArgParser
     void argCompletionBash();
     void argCompletionZsh();
  
-    void usage(std::string const& message);
     void checkCompletion();
     void handleArgFileArguments();
     void handleBashArguments();
@@ -2174,15 +2174,7 @@ ArgParser::argEndCopyAttachments()
 void
 ArgParser::usage(std::string const& message)
 {
-    if (this->ap.isCompleting())
-    {
-        // This will cause bash to fall back to regular file completion.
-        exit(0);
-    }
-    else
-    {
-        throw QPDFArgParser::Usage(message);
-    }
+    this->ap.usage(message);
 }
  
 std::vector<int>