Refactor: streamline `Stream` dictionary access and simplify `isRootMetadata` logic

m-holger
1 parent d1af5099
Showing 2 changed files with 4 additions and 5 deletions
libqpdf/QPDF_Stream.cc
libqpdf/qpdf/QPDFObjectHandle_private.hh
@@ -376,11 +376,10 @@ Stream::getRawStreamData()
 bool
 Stream::isRootMetadata() const
 {
-    if (!getDict().isDictionaryOfType("/Metadata", "/XML")) {
+    if (!stream()->stream_dict.isDictionaryOfType("/Metadata", "/XML")) {
         return false;
     }
-    auto root_metadata = qpdf()->getRoot().getKey("/Metadata");
-    return root_metadata.isSameObjectAs(obj);
+    return qpdf()->getRoot()["/Metadata"].isSameObjectAs(obj);
 }
  
 bool
@@ -469,10 +469,10 @@ namespace qpdf
             qpdf_offset_t offset,
             size_t length);
  
-        QPDFObjectHandle
+        Dictionary
         getDict() const
         {
-            return stream()->stream_dict;
+            return {stream()->stream_dict};
         }
         bool
         isDataModified() const