Refactor QPDFValue::getDescription

Remove parameters and return the description.

Refactor QPDFValue::getDescription
Remove parameters and return the description.
m-holger · Jay Berkenbilt
1 parent 0ef2def8
Showing 4 changed files with 12 additions and 16 deletions
libqpdf/QPDF_Dictionary.cc
libqpdf/QPDF_Stream.cc
libqpdf/qpdf/QPDFObject_private.hh
libqpdf/qpdf/QPDFValue.hh
@@ -84,12 +84,10 @@ QPDF_Dictionary::getKey(std::string const&amp; key)
         // May be a null object
         return item->second;
     } else {
-        QPDFObjectHandle null = QPDFObjectHandle::newNull();
-        QPDF* qpdf = nullptr;
-        std::string description;
-        if (getDescription(qpdf, description)) {
+        auto null = QPDFObjectHandle::newNull();
+        if (qpdf != nullptr) {
             null.setObjectDescription(
-                qpdf, description + " -> dictionary key " + key);
+                qpdf, getDescription() + " -> dictionary key " + key);
         }
         return null;
     }
@@ -292,12 +292,9 @@ QPDF_Stream::setDescription(
 void
 QPDF_Stream::setDictDescription()
 {
-    QPDF* qpdf = nullptr;
-    std::string description;
-    if ((!this->stream_dict.hasObjectDescription()) &&
-        getDescription(qpdf, description)) {
+    if (!this->stream_dict.hasObjectDescription()) {
         this->stream_dict.setObjectDescription(
-            qpdf, description + " -> stream dictionary");
+            qpdf, getDescription() + " -> stream dictionary");
     }
 }
@@ -79,7 +79,9 @@ class QPDFObject
     bool
     getDescription(QPDF*& qpdf, std::string& description)
     {
-        return value->getDescription(qpdf, description);
+        qpdf = value->qpdf;
+        description = value->getDescription();
+        return qpdf != nullptr;
     }
     bool
     hasDescription()
@@ -44,11 +44,10 @@ class QPDFValue
         qpdf = a_qpdf;
         og = a_og;
     }
-    bool
-    getDescription(QPDF*& qpdf_p, std::string& description)
+    std::string
+    getDescription()
     {
-        qpdf_p = qpdf;
-        description = object_description ? *object_description : "";
+        auto description = object_description ? *object_description : "";
         if (auto pos = description.find("$OG"); pos != std::string::npos) {
             description.replace(pos, 3, og.unparse(' '));
         }
@@ -59,7 +58,7 @@ class QPDFValue
             description.replace(pos, 3, std::to_string(parsed_offset + shift));
         }
-        return qpdf != nullptr;
+        return description;
     }
     bool
     hasDescription()