In `QPDFJob` add warning for exceeded configurable limits

- Add warning with associated documentation links. - Update tests to reflect the new warning messages.

In `QPDFJob` add warning for exceeded configurable limits
- Add warning with associated documentation links. - Update tests to reflect the new warning messages.
m-holger
1 parent 1d6da600
Showing 7 changed files with 12 additions and 1 deletions
libqpdf/QPDFJob.cc
libqpdf/QPDFJob_json.cc
qpdf/qtest/qpdf/global1.out
qpdf/qtest/qpdf/global2.out
qpdf/qtest/qpdf/global3.out
qpdf/qtest/qpdf/global4.out
qpdf/qtest/qpdf/issue-202.out
@@ -25,6 +25,7 @@
 #include <qpdf/QTC.hh>
 #include <qpdf/QUtil.hh>
 #include <qpdf/Util.hh>
+#include <qpdf/global_private.hh>
 #include <qpdf/auto_job_schema.hh> // JOB_SCHEMA_DATA
@@ -485,6 +486,11 @@ QPDFJob::writeQPDF(QPDF&amp; pdf)
             *m->log->getWarn() << m->message_prefix << ": operation succeeded with warnings\n";
         }
     }
+    if (!m->d_cfg.suppress_warnings() && global::Limits::errors()) {
+        *m->log->getWarn() << m->message_prefix
+                           << ": some configurable limits were exceeded; for more details "
+                              "see https://qpdf.readthedocs.io/en/stable/cli.html#global-limits\n";
+    }
     if (m->report_mem_usage) {
         // Call get_max_memory_usage before generating output. When debugging, it's easier if print
         // statements from get_max_memory_usage are not interleaved with the output.
@@ -623,7 +623,7 @@ Handlers::beginSetPageLabelsArray(JSON)
 void
 Handlers::beginGlobal(JSON)
 {
-    this->c_global = c_main->global();
+    c_global = c_main->global();
 }
 void
@@ -5,3 +5,4 @@ WARNING: global.pdf: Attempting to reconstruct cross-reference table
 WARNING: global.pdf (trailer, offset 759): limits error(parser-max-nesting): ignoring excessively deeply nested data structure
 WARNING: global.pdf: unable to find trailer dictionary while recovering damaged file
 qpdf: operation succeeded with warnings; resulting file may have some problems
+qpdf: some configurable limits were exceeded; for more details see https://qpdf.readthedocs.io/en/stable/cli.html#global-limits
@@ -6,3 +6,4 @@ WARNING: global_damaged.pdf (trailer, offset 767): unknown token while reading o
 WARNING: global_damaged.pdf (trailer, offset 767): limits error(parser-max-errors): too many errors during parsing; treating object as null
 WARNING: global_damaged.pdf: unable to find trailer dictionary while recovering damaged file
 qpdf: operation succeeded with warnings; resulting file may have some problems
+qpdf: some configurable limits were exceeded; for more details see https://qpdf.readthedocs.io/en/stable/cli.html#global-limits
@@ -3,3 +3,4 @@ WARNING: global.pdf: file is damaged
 WARNING: global.pdf (offset 712): expected trailer dictionary
 WARNING: global.pdf: Attempting to reconstruct cross-reference table
 qpdf: operation succeeded with warnings; resulting file may have some problems
+qpdf: some configurable limits were exceeded; for more details see https://qpdf.readthedocs.io/en/stable/cli.html#global-limits
@@ -7,3 +7,4 @@ WARNING: global_damaged.pdf (trailer, offset 770): unknown token while reading o
 WARNING: global_damaged.pdf (trailer, offset 788): limits error(parser-max-container-size-damaged): encountered errors while parsing an array or dictionary with more than 9 elements; giving up on reading object
 WARNING: global_damaged.pdf: unable to find trailer dictionary while recovering damaged file
 qpdf: operation succeeded with warnings; resulting file may have some problems
+qpdf: some configurable limits were exceeded; for more details see https://qpdf.readthedocs.io/en/stable/cli.html#global-limits
@@ -7,3 +7,4 @@ WARNING: issue-202.pdf (object 222 0, offset 50101): dictionary has duplicated k
 WARNING: issue-202.pdf (object 222 0, offset 50101): dictionary has duplicated key /Producer; last occurrence overrides earlier ones
 WARNING: issue-202.pdf: unable to find trailer dictionary while recovering damaged file
 qpdf: operation succeeded with warnings; resulting file may have some problems
+qpdf: some configurable limits were exceeded; for more details see https://qpdf.readthedocs.io/en/stable/cli.html#global-limits