Fix infinite loop on small files with progress reporting (fixes #230)

Turns out you can keep adding zero to a number over and over again and it just doesn't get any bigger. Who would have known?

Fix infinite loop on small files with progress reporting (fixes #230)
Turns out you can keep adding zero to a number over and over again and it just doesn't get any bigger. Who would have known?
Jay Berkenbilt
1 parent 651b51f0
Showing 4 changed files with 21 additions and 1 deletions
ChangeLog
libqpdf/QPDFWriter.cc
qpdf/qtest/qpdf.test
qpdf/qtest/qpdf/small-progress.out
+2018-08-05  Jay Berkenbilt  <ejb@ql.org>
+
+	* Bug fix: infinite loop on progress reporting for very small
+	files. Fixes #230.
+
 2018-08-04  Jay Berkenbilt  <ejb@ql.org>
 	* Performance fix: optimize page merging operation to avoid
@@ -3357,9 +3357,10 @@ QPDFWriter::indicateProgress(bool decrement, bool finished)
                                 this->m->events_expected)));
         this->m->progress_reporter->reportProgress(percentage);
     }
+    int increment = std::max(1, (this->m->events_expected / 100));
     while (this->m->events_seen >= this->m->next_progress_report)
     {
-        this->m->next_progress_report += (this->m->events_expected / 100);
+        this->m->next_progress_report += increment;
     }
 }
@@ -927,6 +927,17 @@ $td-&gt;runtest(&quot;don&#39;t overwrite self&quot;,
 show_ntests();
 # ----------
+$td->notify("--- Progress reporting ---");
+$n_tests += 1;
+
+$td->runtest("progress report on small file",
+             {$td->COMMAND => "qpdf --progress minimal.pdf a.pdf",
+                  $td->FILTER => "perl filter-progress.pl"},
+             {$td->FILE => "small-progress.out", $td->EXIT_STATUS => 0},
+             $td->NORMALIZE_NEWLINES);
+
+show_ntests();
+# ----------
 $td->notify("--- Type checks ---");
 $n_tests += 4;
 # Whenever object-types.pdf is edited, object-types-os.pdf should be
+qpdf: a.pdf: write progress: 0%
+....other write progress....
+qpdf: a.pdf: write progress: 100%