Commit d780954bb31dbf98af2ed61a00e22cf7680dd42c

Authored by Jay Berkenbilt
1 parent 416d9668

Add some missing QPDF_DLL markers

These markers are being added for nested classes that are already
marked with QPDF_DLL_CLASS. They don't make any different on Linux,
but they matter on Windows.
ChangeLog
1 2022-09-12 Jay Berkenbilt <ejb@ql.org> 1 2022-09-12 Jay Berkenbilt <ejb@ql.org>
2 2
  3 + * Add some missing DLL exports that only affect the Windows build.
  4 +
3 * Remove compile-time test for LL_FMT. It's unlikely that any 5 * Remove compile-time test for LL_FMT. It's unlikely that any
4 compiler new enough to build qpdf still doesn't support %lld. 6 compiler new enough to build qpdf still doesn't support %lld.
5 7
include/qpdf/InputSource.hh
@@ -47,7 +47,9 @@ class QPDF_DLL_CLASS InputSource @@ -47,7 +47,9 @@ class QPDF_DLL_CLASS InputSource
47 class QPDF_DLL_CLASS Finder 47 class QPDF_DLL_CLASS Finder
48 { 48 {
49 public: 49 public:
  50 + QPDF_DLL
50 Finder() = default; 51 Finder() = default;
  52 + QPDF_DLL
51 virtual ~Finder() = default; 53 virtual ~Finder() = default;
52 virtual bool check() = 0; 54 virtual bool check() = 0;
53 }; 55 };
include/qpdf/Pl_DCT.hh
@@ -41,7 +41,9 @@ class QPDF_DLL_CLASS Pl_DCT: public Pipeline @@ -41,7 +41,9 @@ class QPDF_DLL_CLASS Pl_DCT: public Pipeline
41 class QPDF_DLL_CLASS CompressConfig 41 class QPDF_DLL_CLASS CompressConfig
42 { 42 {
43 public: 43 public:
  44 + QPDF_DLL
44 CompressConfig() = default; 45 CompressConfig() = default;
  46 + QPDF_DLL
45 virtual ~CompressConfig() = default; 47 virtual ~CompressConfig() = default;
46 virtual void apply(jpeg_compress_struct*) = 0; 48 virtual void apply(jpeg_compress_struct*) = 0;
47 }; 49 };
include/qpdf/QPDFWriter.hh
@@ -81,6 +81,7 @@ class QPDFWriter @@ -81,6 +81,7 @@ class QPDFWriter
81 class QPDF_DLL_CLASS ProgressReporter 81 class QPDF_DLL_CLASS ProgressReporter
82 { 82 {
83 public: 83 public:
  84 + QPDF_DLL
84 virtual ~ProgressReporter(); 85 virtual ~ProgressReporter();
85 86
86 // This method is called with a value from 0 to 100 to 87 // This method is called with a value from 0 to 100 to
@@ -95,8 +96,11 @@ class QPDFWriter @@ -95,8 +96,11 @@ class QPDFWriter
95 class QPDF_DLL_CLASS FunctionProgressReporter: public ProgressReporter 96 class QPDF_DLL_CLASS FunctionProgressReporter: public ProgressReporter
96 { 97 {
97 public: 98 public:
  99 + QPDF_DLL
98 FunctionProgressReporter(std::function<void(int)>); 100 FunctionProgressReporter(std::function<void(int)>);
  101 + QPDF_DLL
99 virtual ~FunctionProgressReporter(); 102 virtual ~FunctionProgressReporter();
  103 + QPDF_DLL
100 virtual void reportProgress(int) override; 104 virtual void reportProgress(int) override;
101 105
102 private: 106 private:
manual/release-notes.rst
@@ -14,6 +14,9 @@ For a detailed list of changes, please see the file @@ -14,6 +14,9 @@ For a detailed list of changes, please see the file
14 - Remove ``LL_FMT`` tests, which were broken for cross 14 - Remove ``LL_FMT`` tests, which were broken for cross
15 compilation. The code just uses ``%lld`` now. 15 compilation. The code just uses ``%lld`` now.
16 16
  17 + - Some symbols were not properly exported for the Windows DLL
  18 + build.
  19 +
17 11.0.0: September 10, 2022 20 11.0.0: September 10, 2022
18 - Replacement of ``PointerHolder`` with ``std::shared_ptr`` 21 - Replacement of ``PointerHolder`` with ``std::shared_ptr``
19 22