Bug fix: don't compress hint streams when --compress-streams=n

Jay Berkenbilt
1 parent c5f622a0
Showing 12 changed files with 28 additions and 14 deletions
ChangeLog
include/qpdf/QPDF.hh
libqpdf/QPDFWriter.cc
libqpdf/QPDF_linearization.cc
qpdf/qtest/qpdf/job-json-misc-options.pdf
qpdf/qtest/qpdf/lin-special.disable.exp
qpdf/qtest/qpdf/lin-special.generate.exp
qpdf/qtest/qpdf/lin-special.preserve.exp
qpdf/qtest/qpdf/object-stream.disable.exp
qpdf/qtest/qpdf/object-stream.generate.exp
qpdf/qtest/qpdf/object-stream.preserve.exp
qpdf/qtest/qpdf/replaced-stream-data-flate.pdf
 2023-12-20  Jay Berkenbilt  <ejb@ql.org>
-	* Bug fix: with --compress-streams=n, don't compress object or
-	XRef streams.
+	* Bug fix: with --compress-streams=n, don't compress object, XRef,
+	or linearization hint streams.
 2023-12-16  Jay Berkenbilt  <ejb@ql.org>
@@ -745,9 +745,10 @@ class QPDF
             std::map<int, int> const& obj_renumber,
             std::shared_ptr<Buffer>& hint_stream,
             int& S,
-            int& O)
+            int& O,
+            bool compressed)
         {
-            return qpdf.generateHintStream(xref, lengths, obj_renumber, hint_stream, S, O);
+            return qpdf.generateHintStream(xref, lengths, obj_renumber, hint_stream, S, O, compressed);
         }
         static void
@@ -1094,7 +1095,8 @@ class QPDF
         std::map<int, int> const& obj_renumber,
         std::shared_ptr<Buffer>& hint_stream,
         int& S,
-        int& O);
+        int& O,
+        bool compressed);
     // Map object to object stream that contains it
     void getObjectStreamData(std::map<int, int>&);
@@ -2289,15 +2289,20 @@ QPDFWriter::writeHintStream(int hint_id)
     std::shared_ptr<Buffer> hint_buffer;
     int S = 0;
     int O = 0;
+    bool compressed = (m->compress_streams && !m->qdf_mode);
     QPDF::Writer::generateHintStream(
-        m->pdf, m->xref, m->lengths, m->obj_renumber_no_gen, hint_buffer, S, O);
+        m->pdf, m->xref, m->lengths, m->obj_renumber_no_gen, hint_buffer, S, O, compressed);
     openObject(hint_id);
     setDataKey(hint_id);
     size_t hlen = hint_buffer->getSize();
-    writeString("<< /Filter /FlateDecode /S ");
+    writeString("<< ");
+    if (compressed) {
+        writeString("/Filter /FlateDecode ");
+    }
+    writeString("/S ");
     writeString(std::to_string(S));
     if (O) {
         writeString(" /O ");
@@ -1748,10 +1748,10 @@ QPDF::writeHSharedObject(BitWriter&amp; w)
 void
 QPDF::writeHGeneric(BitWriter& w, HGeneric& t)
 {
-    w.writeBitsInt(t.first_object, 32);             // 1
-    w.writeBits(toULL(t.first_object_offset), 32);  // 2
-    w.writeBitsInt(t.nobjects, 32);                 // 3
-    w.writeBitsInt(t.group_length, 32);             // 4
+    w.writeBitsInt(t.first_object, 32);            // 1
+    w.writeBits(toULL(t.first_object_offset), 32); // 2
+    w.writeBitsInt(t.nobjects, 32);                // 3
+    w.writeBitsInt(t.group_length, 32);            // 4
 }
 void
@@ -1761,7 +1761,8 @@ QPDF::generateHintStream(
     std::map<int, int> const& obj_renumber,
     std::shared_ptr<Buffer>& hint_buffer,
     int& S,
-    int& O)
+    int& O,
+    bool compressed)
 {
     // Populate actual hint table values
     calculateHPageOffset(xref, lengths, obj_renumber);
@@ -1771,8 +1772,14 @@ QPDF::generateHintStream(
     // Write the hint stream itself into a compressed memory buffer. Write through a counter so we
     // can get offsets.
     Pl_Buffer hint_stream("hint stream");
-    Pl_Flate f("compress hint stream", &hint_stream, Pl_Flate::a_deflate);
-    Pl_Count c("count", &f);
+    Pipeline* next = &hint_stream;
+    std::shared_ptr<Pipeline> flate;
+    if (compressed) {
+        flate =
+            std::make_shared<Pl_Flate>("compress hint stream", &hint_stream, Pl_Flate::a_deflate);
+        next = flate.get();
+    }
+    Pl_Count c("count", next);
     BitWriter w(&c);
     writeHPageOffset(w);