Commit d55ee8f95d0227224d14dfd9e9c75913b034170b
1 parent
e1af26a3
Minor fixes to release instructions
Showing
1 changed file
with
8 additions
and
2 deletions
README-maintainer.md
| @@ -607,6 +607,12 @@ When done, the following should happen: | @@ -607,6 +607,12 @@ When done, the following should happen: | ||
| 607 | 607 | ||
| 608 | ## CREATING A RELEASE | 608 | ## CREATING A RELEASE |
| 609 | 609 | ||
| 610 | +* Until qpdf 13: see also README-maintainer.md from v12.2.0 for | ||
| 611 | + additional gpg signing steps. This includes signing the releases | ||
| 612 | + with gpg. Do this before running cosign. Also use `git tag -s` | ||
| 613 | + instead of `git tag -a`. When we deprecate gpg signing, this can be | ||
| 614 | + removed. | ||
| 615 | + | ||
| 610 | * Releases are signed using | 616 | * Releases are signed using |
| 611 | [cosign](https://docs.sigstore.dev/quickstart/quickstart-cosign/) | 617 | [cosign](https://docs.sigstore.dev/quickstart/quickstart-cosign/) |
| 612 | using your GitHub identity. If you are creating a release, please | 618 | using your GitHub identity. If you are creating a release, please |
| @@ -649,7 +655,7 @@ chmod 555 *.AppImage | @@ -649,7 +655,7 @@ chmod 555 *.AppImage | ||
| 649 | 655 | ||
| 650 | ```sh | 656 | ```sh |
| 651 | git rev-parse qpdf/main @ | 657 | git rev-parse qpdf/main @ |
| 652 | -git tag -s v$version @ -m"qpdf $version" | 658 | +git tag -a v$version @ -m"qpdf $version" |
| 653 | git push qpdf v$version | 659 | git push qpdf v$version |
| 654 | ``` | 660 | ``` |
| 655 | 661 | ||
| @@ -673,7 +679,7 @@ git push qpdf @:stable | @@ -673,7 +679,7 @@ git push qpdf @:stable | ||
| 673 | GITHUB_TOKEN=$(qdata-show cred github-token) | 679 | GITHUB_TOKEN=$(qdata-show cred github-token) |
| 674 | function gcurl() { curl -H "Authorization: token $GITHUB_TOKEN" ${1+"$@"}; } | 680 | function gcurl() { curl -H "Authorization: token $GITHUB_TOKEN" ${1+"$@"}; } |
| 675 | 681 | ||
| 676 | -url=$(gcurl -s -XPOST https://api.github.com/repos/qpdf/qpdf/releases -d'{"tag_name": "v'$version'", "name": "qpdf '$ver | 682 | +url=$(gcurl -s -XPOST https://api.github.com/repos/qpdf/qpdf/releases -d'{"tag_name": "v'$version'", "name": "qpdf '$version'", "draft": true}' | jq -r '.url') |
| 677 | 683 | ||
| 678 | # Get upload url | 684 | # Get upload url |
| 679 | upload_url=$(gcurl -s $url | jq -r '.upload_url' | sed -E -e 's/\{.*\}//') | 685 | upload_url=$(gcurl -s $url | jq -r '.upload_url' | sed -E -e 's/\{.*\}//') |