Commit d2f397594803fa5729fab83684ce74184dd4fe38
1 parent
cc500eda
Add missing virtual destructors to all helper classes
Showing
7 changed files
with
28 additions
and
0 deletions
include/qpdf/QPDFAcroFormDocumentHelper.hh
| @@ -85,6 +85,10 @@ class QPDFAcroFormDocumentHelper: public QPDFDocumentHelper | @@ -85,6 +85,10 @@ class QPDFAcroFormDocumentHelper: public QPDFDocumentHelper | ||
| 85 | public: | 85 | public: |
| 86 | QPDF_DLL | 86 | QPDF_DLL |
| 87 | QPDFAcroFormDocumentHelper(QPDF&); | 87 | QPDFAcroFormDocumentHelper(QPDF&); |
| 88 | + QPDF_DLL | ||
| 89 | + virtual ~QPDFAcroFormDocumentHelper() | ||
| 90 | + { | ||
| 91 | + } | ||
| 88 | 92 | ||
| 89 | // This class lazily creates an internal cache of the mapping | 93 | // This class lazily creates an internal cache of the mapping |
| 90 | // among form fields, annotations, and pages. Methods within this | 94 | // among form fields, annotations, and pages. Methods within this |
include/qpdf/QPDFAnnotationObjectHelper.hh
| @@ -31,6 +31,10 @@ class QPDFAnnotationObjectHelper: public QPDFObjectHelper | @@ -31,6 +31,10 @@ class QPDFAnnotationObjectHelper: public QPDFObjectHelper | ||
| 31 | public: | 31 | public: |
| 32 | QPDF_DLL | 32 | QPDF_DLL |
| 33 | QPDFAnnotationObjectHelper(QPDFObjectHandle); | 33 | QPDFAnnotationObjectHelper(QPDFObjectHandle); |
| 34 | + QPDF_DLL | ||
| 35 | + virtual ~QPDFAnnotationObjectHelper() | ||
| 36 | + { | ||
| 37 | + } | ||
| 34 | 38 | ||
| 35 | // This class provides helper methods for certain types of | 39 | // This class provides helper methods for certain types of |
| 36 | // annotations. At its introduction, it only supports Widget | 40 | // annotations. At its introduction, it only supports Widget |
include/qpdf/QPDFFormFieldObjectHelper.hh
| @@ -37,6 +37,10 @@ class QPDFFormFieldObjectHelper: public QPDFObjectHelper | @@ -37,6 +37,10 @@ class QPDFFormFieldObjectHelper: public QPDFObjectHelper | ||
| 37 | QPDFFormFieldObjectHelper(); | 37 | QPDFFormFieldObjectHelper(); |
| 38 | QPDF_DLL | 38 | QPDF_DLL |
| 39 | QPDFFormFieldObjectHelper(QPDFObjectHandle); | 39 | QPDFFormFieldObjectHelper(QPDFObjectHandle); |
| 40 | + QPDF_DLL | ||
| 41 | + virtual ~QPDFFormFieldObjectHelper() | ||
| 42 | + { | ||
| 43 | + } | ||
| 40 | 44 | ||
| 41 | QPDF_DLL | 45 | QPDF_DLL |
| 42 | bool isNull(); | 46 | bool isNull(); |
include/qpdf/QPDFNumberTreeObjectHelper.hh
| @@ -41,6 +41,10 @@ class QPDFNumberTreeObjectHelper: public QPDFObjectHelper | @@ -41,6 +41,10 @@ class QPDFNumberTreeObjectHelper: public QPDFObjectHelper | ||
| 41 | public: | 41 | public: |
| 42 | QPDF_DLL | 42 | QPDF_DLL |
| 43 | QPDFNumberTreeObjectHelper(QPDFObjectHandle); | 43 | QPDFNumberTreeObjectHelper(QPDFObjectHandle); |
| 44 | + QPDF_DLL | ||
| 45 | + virtual ~QPDFNumberTreeObjectHelper() | ||
| 46 | + { | ||
| 47 | + } | ||
| 44 | 48 | ||
| 45 | typedef long long int numtree_number; | 49 | typedef long long int numtree_number; |
| 46 | 50 |
include/qpdf/QPDFPageDocumentHelper.hh
| @@ -36,6 +36,10 @@ class QPDFPageDocumentHelper: public QPDFDocumentHelper | @@ -36,6 +36,10 @@ class QPDFPageDocumentHelper: public QPDFDocumentHelper | ||
| 36 | public: | 36 | public: |
| 37 | QPDF_DLL | 37 | QPDF_DLL |
| 38 | QPDFPageDocumentHelper(QPDF&); | 38 | QPDFPageDocumentHelper(QPDF&); |
| 39 | + QPDF_DLL | ||
| 40 | + virtual ~QPDFPageDocumentHelper() | ||
| 41 | + { | ||
| 42 | + } | ||
| 39 | 43 | ||
| 40 | // Traverse page tree, and return all /Page objects wrapped in | 44 | // Traverse page tree, and return all /Page objects wrapped in |
| 41 | // QPDFPageObjectHelper objects. Unlike with | 45 | // QPDFPageObjectHelper objects. Unlike with |
include/qpdf/QPDFPageLabelDocumentHelper.hh
| @@ -49,6 +49,10 @@ class QPDFPageLabelDocumentHelper: public QPDFDocumentHelper | @@ -49,6 +49,10 @@ class QPDFPageLabelDocumentHelper: public QPDFDocumentHelper | ||
| 49 | public: | 49 | public: |
| 50 | QPDF_DLL | 50 | QPDF_DLL |
| 51 | QPDFPageLabelDocumentHelper(QPDF&); | 51 | QPDFPageLabelDocumentHelper(QPDF&); |
| 52 | + QPDF_DLL | ||
| 53 | + virtual ~QPDFPageLabelDocumentHelper() | ||
| 54 | + { | ||
| 55 | + } | ||
| 52 | 56 | ||
| 53 | QPDF_DLL | 57 | QPDF_DLL |
| 54 | bool hasPageLabels(); | 58 | bool hasPageLabels(); |
include/qpdf/QPDFPageObjectHelper.hh
| @@ -34,6 +34,10 @@ class QPDFPageObjectHelper: public QPDFObjectHelper | @@ -34,6 +34,10 @@ class QPDFPageObjectHelper: public QPDFObjectHelper | ||
| 34 | public: | 34 | public: |
| 35 | QPDF_DLL | 35 | QPDF_DLL |
| 36 | QPDFPageObjectHelper(QPDFObjectHandle); | 36 | QPDFPageObjectHelper(QPDFObjectHandle); |
| 37 | + QPDF_DLL | ||
| 38 | + virtual ~QPDFPageObjectHelper() | ||
| 39 | + { | ||
| 40 | + } | ||
| 37 | 41 | ||
| 38 | // Returns an empty map if there are no images or no resources. | 42 | // Returns an empty map if there are no images or no resources. |
| 39 | // This function does not presently support inherited resources. | 43 | // This function does not presently support inherited resources. |