Commit c95f02115c11c1dd16eec6cc806ba2788d9b39bc
1 parent
dd3b2ced
Doc updates from m-holger
Showing
1 changed file
with
11 additions
and
11 deletions
manual/qpdf-job.rst
| @@ -27,7 +27,7 @@ executable is available from inside the C++ library using the | @@ -27,7 +27,7 @@ executable is available from inside the C++ library using the | ||
| 27 | - The ``QPDFJob`` C++ API | 27 | - The ``QPDFJob`` C++ API |
| 28 | 28 | ||
| 29 | If you can understand how to use the :command:`qpdf` CLI, you can | 29 | If you can understand how to use the :command:`qpdf` CLI, you can |
| 30 | -understand the ``QPDFJob`` class and the json file. qpdf guarantees | 30 | +understand the ``QPDFJob`` class and the JSON file. qpdf guarantees |
| 31 | that all of the above methods are in sync. Here's how it works: | 31 | that all of the above methods are in sync. Here's how it works: |
| 32 | 32 | ||
| 33 | .. list-table:: QPDFJob Interfaces | 33 | .. list-table:: QPDFJob Interfaces |
| @@ -55,8 +55,8 @@ keys are command-line flags converted to camelCase. Positional | @@ -55,8 +55,8 @@ keys are command-line flags converted to camelCase. Positional | ||
| 55 | arguments have some corresponding key, which you can find by running | 55 | arguments have some corresponding key, which you can find by running |
| 56 | ``qpdf`` with the :qpdf:ref:`--job-json-help` flag. For example, input | 56 | ``qpdf`` with the :qpdf:ref:`--job-json-help` flag. For example, input |
| 57 | and output files are named by positional arguments on the CLI. In the | 57 | and output files are named by positional arguments on the CLI. In the |
| 58 | -JSON, they are ``"inputFile"`` and ``"outputFile"``. The following are | ||
| 59 | -equivalent: | 58 | +JSON, they appear in the ``"inputFile"`` and ``"outputFile"`` keys. |
| 59 | +The following are equivalent: | ||
| 60 | 60 | ||
| 61 | .. It would be nice to have an automated test that these are all the | 61 | .. It would be nice to have an automated test that these are all the |
| 62 | same, but we have so few live examples that it's not worth it for | 62 | same, but we have so few live examples that it's not worth it for |
| @@ -135,7 +135,7 @@ C++ code: | @@ -135,7 +135,7 @@ C++ code: | ||
| 135 | return 0; | 135 | return 0; |
| 136 | } | 136 | } |
| 137 | 137 | ||
| 138 | -It is also possible to mix and match command-line options and json | 138 | +It is also possible to mix and match command-line options and JSON |
| 139 | from the CLI. For example, you could create a file called | 139 | from the CLI. For example, you could create a file called |
| 140 | :file:`my-options.json` containing the following: | 140 | :file:`my-options.json` containing the following: |
| 141 | 141 | ||
| @@ -174,7 +174,7 @@ This section describes some of the design rationale and history behind | @@ -174,7 +174,7 @@ This section describes some of the design rationale and history behind | ||
| 174 | Documentation of ``QPDFJob`` is divided among three places: | 174 | Documentation of ``QPDFJob`` is divided among three places: |
| 175 | 175 | ||
| 176 | - "HOW TO ADD A COMMAND-LINE ARGUMENT" in :file:`README-maintainer` | 176 | - "HOW TO ADD A COMMAND-LINE ARGUMENT" in :file:`README-maintainer` |
| 177 | - provides a quick reminder for how to add a command-line argument | 177 | + provides a quick reminder of how to add a command-line argument |
| 178 | 178 | ||
| 179 | - The source file :file:`generate_auto_job` has a detailed explanation | 179 | - The source file :file:`generate_auto_job` has a detailed explanation |
| 180 | about how ``QPDFJob`` and ``generate_auto_job`` work together | 180 | about how ``QPDFJob`` and ``generate_auto_job`` work together |
| @@ -182,11 +182,11 @@ Documentation of ``QPDFJob`` is divided among three places: | @@ -182,11 +182,11 @@ Documentation of ``QPDFJob`` is divided among three places: | ||
| 182 | - This chapter of the manual has other details. | 182 | - This chapter of the manual has other details. |
| 183 | 183 | ||
| 184 | Prior to qpdf version 10.6.0, the qpdf CLI executable had a lot of | 184 | Prior to qpdf version 10.6.0, the qpdf CLI executable had a lot of |
| 185 | -functionality built into the executable that was not callable from the | ||
| 186 | -library as such. This created a number of problems: | 185 | +functionality built into it that was not callable from the library as |
| 186 | +such. This created a number of problems: | ||
| 187 | 187 | ||
| 188 | - Some of the logic in :file:`qpdf.cc` was pretty complex, such as | 188 | - Some of the logic in :file:`qpdf.cc` was pretty complex, such as |
| 189 | - image optimization, generating json output, and many of the page | 189 | + image optimization, generating JSON output, and many of the page |
| 190 | manipulations. While those things could all be coded using the C++ | 190 | manipulations. While those things could all be coded using the C++ |
| 191 | API, there would be a lot of duplicated code. | 191 | API, there would be a lot of duplicated code. |
| 192 | 192 | ||
| @@ -212,7 +212,7 @@ Here are a few notes on some design decisions about QPDFJob and its | @@ -212,7 +212,7 @@ Here are a few notes on some design decisions about QPDFJob and its | ||
| 212 | various interfaces. | 212 | various interfaces. |
| 213 | 213 | ||
| 214 | - Bare command-line options (flags with no parameter) map to config | 214 | - Bare command-line options (flags with no parameter) map to config |
| 215 | - functions that take no options and to json keys whose values are | 215 | + functions that take no options and to JSON keys whose values are |
| 216 | required to be the empty string. The rationale is that we can later | 216 | required to be the empty string. The rationale is that we can later |
| 217 | change these bare options to options that take an optional parameter | 217 | change these bare options to options that take an optional parameter |
| 218 | without breaking backward compatibility in the CLI or the JSON. | 218 | without breaking backward compatibility in the CLI or the JSON. |
| @@ -244,5 +244,5 @@ various interfaces. | @@ -244,5 +244,5 @@ various interfaces. | ||
| 244 | Config class, adding a config member variable to ``ArgParser`` in | 244 | Config class, adding a config member variable to ``ArgParser`` in |
| 245 | :file:`QPDFJob_argv.cc` and ``Handlers`` in :file:`QPDFJob_json.cc`, | 245 | :file:`QPDFJob_argv.cc` and ``Handlers`` in :file:`QPDFJob_json.cc`, |
| 246 | and make sure that manually implemented handlers are consistent with | 246 | and make sure that manually implemented handlers are consistent with |
| 247 | - each other. It is best under the cases to explicit test cases for | ||
| 248 | - all the various ways to get to the option. | 247 | + each other. It is best to add explicit test cases for all the |
| 248 | + various ways to get to the option. |