Treat direct page as runtime rather than logic error (fuzz issue 27393)

Jay Berkenbilt
1 parent a7ef572c
Showing 3 changed files with 11 additions and 3 deletions
ChangeLog
fuzz/qpdf_extra/27393.fuzz
libqpdf/QPDFObjectHandle.cc
+2020-11-11  Jay Berkenbilt  <ejb@ql.org>
+
+	* Treat a direct page object as a runtime error rather than a
+	logic error since it is actually possible to create a file that
+	has this (fuzz issue 27393).
+
 2020-11-09  Jay Berkenbilt  <ejb@ql.org>
  
 	* Handle "." appearing in --pages not preceded by a numeric range
@@ -1512,9 +1512,11 @@ QPDFObjectHandle::coalesceContentStreams()
     {
         // Should not be possible for a page object to not have an
         // owning PDF unless it was manually constructed in some
-        // incorrect way.
-        throw std::logic_error("coalesceContentStreams called on object"
-                               " with no associated PDF file");
+        // incorrect way. However, it can happen in a PDF file whose
+        // page structure is direct, which is against spec but still
+        // possible to hand construct, as in fuzz issue 27393.
+        throw std::runtime_error("coalesceContentStreams called on object"
+                                 " with no associated PDF file");
     }
     QPDFObjectHandle new_contents = newStream(qpdf);
     this->replaceKey("/Contents", new_contents);