Merge pull request #1533 from m-holger/fuzz

Fix `replaceKey` in `BaseDictionary`: update to use `null`/`indirect`…

Merge pull request #1533 from m-holger/fuzz
Fix `replaceKey` in `BaseDictionary`: update to use `null`/`indirect`…
m-holger · GitHub
2 parents d16e822d 73878a80
Showing 4 changed files with 3 additions and 2 deletions
fuzz/CMakeLists.txt
fuzz/qpdf_extra/5828408539152384.fuzz
fuzz/qtest/fuzz.test
libqpdf/QPDF_Dictionary.cc
@@ -163,6 +163,7 @@ set(CORPUS_OTHER
   440747125.fuzz
   4720043549327360.fuzz
   5109284021272576.fuzz
+  5828408539152384.fuzz
   6489005569146880.fuzz
 )
@@ -11,7 +11,7 @@ my $td = new TestDriver(&#39;fuzz&#39;);
 my $qpdf_corpus = $ENV{'QPDF_FUZZ_CORPUS'} || die "must set QPDF_FUZZ_CORPUS";
-my $n_qpdf_files = 101;       # increment when adding new files
+my $n_qpdf_files = 102;       # increment when adding new files
 my @fuzzers = (
     ['ascii85' => 1],
@@ -67,7 +67,7 @@ void
 BaseDictionary::replaceKey(std::string const& key, QPDFObjectHandle value)
 {
     auto d = dict();
-    if (value.isNull() && !value.isIndirect()) {
+    if (value.null() && !value.indirect()) {
         // The PDF spec doesn't distinguish between keys with null values and missing keys.
         // Allow indirect nulls which are equivalent to a dangling reference, which is
         // permitted by the spec.