Merge pull request #947 from m-holger/null

Prevent destruction of shared null objects

Merge pull request #947 from m-holger/null
Prevent destruction of shared null objects
Jay Berkenbilt · GitHub
2 parents 7e77af35 08d7b567
Showing 1 changed file with 3 additions and 2 deletions
libqpdf/QPDF.cc
@@ -247,10 +247,11 @@ QPDF::~QPDF()
     // but we'll explicitly clear the xref table anyway just to
     // prevent any possibility of resolve() succeeding.
     this->m->xref_table.clear();
-    auto null_obj = QPDF_Null::create();
     for (auto const& iter: this->m->obj_cache) {
         iter.second.object->disconnect();
-        iter.second.object->destroy();
+        if (iter.second.object->getTypeCode() != ::ot_null) {
+            iter.second.object->destroy();
+        }
     }
 }