Commit 9893beea8175de786af0561f7e562a5493d1226b
1 parent
dc863a10
Tweak formatting in README-maintainer.md
Showing
1 changed file
with
28 additions
and
5 deletions
README-maintainer.md
| @@ -334,7 +334,9 @@ When done, the following should happen: | @@ -334,7 +334,9 @@ When done, the following should happen: | ||
| 334 | * Each year, update copyright notices. This will find all relevant | 334 | * Each year, update copyright notices. This will find all relevant |
| 335 | places (assuming current copyright is from last year): | 335 | places (assuming current copyright is from last year): |
| 336 | 336 | ||
| 337 | + ``` | ||
| 337 | git --no-pager grep -i -n -P "copyright.*$(expr $(date +%Y) - 1).*berkenbilt" | 338 | git --no-pager grep -i -n -P "copyright.*$(expr $(date +%Y) - 1).*berkenbilt" |
| 339 | + ``` | ||
| 338 | 340 | ||
| 339 | Also update the copyright in these places: | 341 | Also update the copyright in these places: |
| 340 | * debian package -- search for copyright.*berkenbilt in debian/copyright | 342 | * debian package -- search for copyright.*berkenbilt in debian/copyright |
| @@ -350,7 +352,7 @@ When done, the following should happen: | @@ -350,7 +352,7 @@ When done, the following should happen: | ||
| 350 | * Check for open fuzz crashes at https://oss-fuzz.com | 352 | * Check for open fuzz crashes at https://oss-fuzz.com |
| 351 | 353 | ||
| 352 | * Check all open issues and pull requests in github and the | 354 | * Check all open issues and pull requests in github and the |
| 353 | - sourceforge trackers. See ~/scripts/github-issues. Don't forget pull | 355 | + sourceforge trackers. Don't forget pull |
| 354 | requests. Note: If the location for reporting issues changes, do a | 356 | requests. Note: If the location for reporting issues changes, do a |
| 355 | careful check of documentation and code to make sure any comments | 357 | careful check of documentation and code to make sure any comments |
| 356 | that include the issue creation URL are updated. | 358 | that include the issue creation URL are updated. |
| @@ -362,12 +364,16 @@ When done, the following should happen: | @@ -362,12 +364,16 @@ When done, the following should happen: | ||
| 362 | 364 | ||
| 363 | * Make sure the code is formatted. | 365 | * Make sure the code is formatted. |
| 364 | 366 | ||
| 367 | + ``` | ||
| 365 | ./format-code | 368 | ./format-code |
| 369 | + ``` | ||
| 366 | 370 | ||
| 367 | * Run a spelling checker over the source code to catch errors in | 371 | * Run a spelling checker over the source code to catch errors in |
| 368 | variable names, strings, and comments. | 372 | variable names, strings, and comments. |
| 369 | 373 | ||
| 374 | + ``` | ||
| 370 | ./spell-check | 375 | ./spell-check |
| 376 | + ``` | ||
| 371 | 377 | ||
| 372 | This uses cspell. Install with `npm install -g cspell`. The output | 378 | This uses cspell. Install with `npm install -g cspell`. The output |
| 373 | of cspell is suitable for use with `M-x grep` in emacs. Add | 379 | of cspell is suitable for use with `M-x grep` in emacs. Add |
| @@ -376,8 +382,10 @@ When done, the following should happen: | @@ -376,8 +382,10 @@ When done, the following should happen: | ||
| 376 | * If needed, run large file and image comparison tests by setting | 382 | * If needed, run large file and image comparison tests by setting |
| 377 | these environment variables: | 383 | these environment variables: |
| 378 | 384 | ||
| 385 | + ``` | ||
| 379 | QPDF_LARGE_FILE_TEST_PATH=/full/path | 386 | QPDF_LARGE_FILE_TEST_PATH=/full/path |
| 380 | QPDF_TEST_COMPARE_IMAGES=1 | 387 | QPDF_TEST_COMPARE_IMAGES=1 |
| 388 | + ``` | ||
| 381 | 389 | ||
| 382 | For Windows, use a Windows style path, not an MSYS path for large files. | 390 | For Windows, use a Windows style path, not an MSYS path for large files. |
| 383 | 391 | ||
| @@ -413,10 +421,12 @@ When done, the following should happen: | @@ -413,10 +421,12 @@ When done, the following should happen: | ||
| 413 | 421 | ||
| 414 | * Test for performance and binary compatibility: | 422 | * Test for performance and binary compatibility: |
| 415 | 423 | ||
| 424 | + ``` | ||
| 416 | ./abi-perf-test v<old> @ | 425 | ./abi-perf-test v<old> @ |
| 426 | + ``` | ||
| 417 | 427 | ||
| 418 | - Prefix with SKIP_PERF=1 to skip performance test. | ||
| 419 | - Prefix with SKIP_TESTS=1 to skip test suite run. | 428 | + * Prefix with `SKIP_PERF=1` to skip performance test. |
| 429 | + * Prefix with `SKIP_TESTS=1` to skip test suite run. | ||
| 420 | 430 | ||
| 421 | See "ABI checks" for details about the process. | 431 | See "ABI checks" for details about the process. |
| 422 | End state: | 432 | End state: |
| @@ -427,8 +437,9 @@ When done, the following should happen: | @@ -427,8 +437,9 @@ When done, the following should happen: | ||
| 427 | 437 | ||
| 428 | * Run package tests: | 438 | * Run package tests: |
| 429 | 439 | ||
| 430 | -(Note: can't use DESTDIR because pkg-config won't know about it.) | 440 | + (Note: can't use DESTDIR because pkg-config won't know about it.) |
| 431 | 441 | ||
| 442 | +``` | ||
| 432 | \rm -rf /tmp/inst build.tmp | 443 | \rm -rf /tmp/inst build.tmp |
| 433 | cmake -S . -B build.tmp \ | 444 | cmake -S . -B build.tmp \ |
| 434 | -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=/tmp/inst | 445 | -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=/tmp/inst |
| @@ -438,6 +449,7 @@ env PKG_CONFIG_PATH=/tmp/inst/lib/pkgconfig \ | @@ -438,6 +449,7 @@ env PKG_CONFIG_PATH=/tmp/inst/lib/pkgconfig \ | ||
| 438 | LD_LIBRARY_PATH=/tmp/inst/lib \ | 449 | LD_LIBRARY_PATH=/tmp/inst/lib \ |
| 439 | CMAKE_PREFIX_PATH=/tmp/inst \ | 450 | CMAKE_PREFIX_PATH=/tmp/inst \ |
| 440 | ./pkg-test/run-all | 451 | ./pkg-test/run-all |
| 452 | +``` | ||
| 441 | 453 | ||
| 442 | ## CREATING A RELEASE | 454 | ## CREATING A RELEASE |
| 443 | 455 | ||
| @@ -448,8 +460,10 @@ env PKG_CONFIG_PATH=/tmp/inst/lib/pkgconfig \ | @@ -448,8 +460,10 @@ env PKG_CONFIG_PATH=/tmp/inst/lib/pkgconfig \ | ||
| 448 | 460 | ||
| 449 | * Sign the source distribution: | 461 | * Sign the source distribution: |
| 450 | 462 | ||
| 463 | +``` | ||
| 451 | version=x.y.z | 464 | version=x.y.z |
| 452 | gpg --detach-sign --armor qpdf-$version.tar.gz | 465 | gpg --detach-sign --armor qpdf-$version.tar.gz |
| 466 | +``` | ||
| 453 | 467 | ||
| 454 | * Build and test the debian package. This includes running autopkgtest. | 468 | * Build and test the debian package. This includes running autopkgtest. |
| 455 | 469 | ||
| @@ -458,6 +472,7 @@ gpg --detach-sign --armor qpdf-$version.tar.gz | @@ -458,6 +472,7 @@ gpg --detach-sign --armor qpdf-$version.tar.gz | ||
| 458 | 472 | ||
| 459 | * From the release archive area, sign the releases. | 473 | * From the release archive area, sign the releases. |
| 460 | 474 | ||
| 475 | +``` | ||
| 461 | \rm -f *.sha256 | 476 | \rm -f *.sha256 |
| 462 | files=(*) | 477 | files=(*) |
| 463 | sha256sum ${files[*]} >| qpdf-$version.sha256 | 478 | sha256sum ${files[*]} >| qpdf-$version.sha256 |
| @@ -465,6 +480,7 @@ gpg --clearsign --armor qpdf-$version.sha256 | @@ -465,6 +480,7 @@ gpg --clearsign --armor qpdf-$version.sha256 | ||
| 465 | mv qpdf-$version.sha256.asc qpdf-$version.sha256 | 480 | mv qpdf-$version.sha256.asc qpdf-$version.sha256 |
| 466 | chmod 444 * | 481 | chmod 444 * |
| 467 | chmod 555 *.AppImage | 482 | chmod 555 *.AppImage |
| 483 | +``` | ||
| 468 | 484 | ||
| 469 | * When creating releases on github and sourceforge, remember to copy | 485 | * When creating releases on github and sourceforge, remember to copy |
| 470 | `README-what-to-download.md` separately onto the download area if | 486 | `README-what-to-download.md` separately onto the download area if |
| @@ -475,14 +491,18 @@ chmod 555 *.AppImage | @@ -475,14 +491,18 @@ chmod 555 *.AppImage | ||
| 475 | arguments. Create and push a signed tag. This should be run with | 491 | arguments. Create and push a signed tag. This should be run with |
| 476 | HEAD pointing to the tip of main. | 492 | HEAD pointing to the tip of main. |
| 477 | 493 | ||
| 494 | +``` | ||
| 478 | git rev-parse qpdf/main @ | 495 | git rev-parse qpdf/main @ |
| 479 | git tag -s v$version @ -m"qpdf $version" | 496 | git tag -s v$version @ -m"qpdf $version" |
| 480 | git push qpdf v$version | 497 | git push qpdf v$version |
| 498 | +``` | ||
| 481 | 499 | ||
| 482 | * Update documentation branches | 500 | * Update documentation branches |
| 483 | 501 | ||
| 502 | +``` | ||
| 484 | git push qpdf @:$(echo $version | sed -E 's/\.[^\.]+$//') | 503 | git push qpdf @:$(echo $version | sed -E 's/\.[^\.]+$//') |
| 485 | git push qpdf @:stable | 504 | git push qpdf @:stable |
| 505 | +``` | ||
| 486 | 506 | ||
| 487 | * If this is an x.y.0 release, visit | 507 | * If this is an x.y.0 release, visit |
| 488 | https://readthedocs.org/projects/qpdf/versions/ (log in with | 508 | https://readthedocs.org/projects/qpdf/versions/ (log in with |
| @@ -519,7 +539,8 @@ Template for release notes: | @@ -519,7 +539,8 @@ Template for release notes: | ||
| 519 | ``` | 539 | ``` |
| 520 | This is qpdf version x.y.z. (Brief description) | 540 | This is qpdf version x.y.z. (Brief description) |
| 521 | 541 | ||
| 522 | -For a full list of changes from previous releases, please see the [release notes](https://qpdf.readthedocs.io/en/stable/release-notes.html). See also [README-what-to-download](./README-what-to-download.md) for details about the available source and binary distributions. | 542 | +For a full list of changes from previous releases, please see the [release notes](https://qpdf.readthedocs.io/en/stable/release-notes.html). See also [README-what-to-download](./README-what-to-download.md) for details about |
| 543 | +the available source and binary distributions. | ||
| 523 | ``` | 544 | ``` |
| 524 | 545 | ||
| 525 | ``` | 546 | ``` |
| @@ -529,7 +550,9 @@ gcurl -XPOST $url -d'{"draft": false}' | @@ -529,7 +550,9 @@ gcurl -XPOST $url -d'{"draft": false}' | ||
| 529 | 550 | ||
| 530 | * Upload files to sourceforge. | 551 | * Upload files to sourceforge. |
| 531 | 552 | ||
| 553 | +``` | ||
| 532 | rsync -vrlcO ./ jay_berkenbilt,qpdf@frs.sourceforge.net:/home/frs/project/q/qp/qpdf/qpdf/$version/ | 554 | rsync -vrlcO ./ jay_berkenbilt,qpdf@frs.sourceforge.net:/home/frs/project/q/qp/qpdf/qpdf/$version/ |
| 555 | +``` | ||
| 533 | 556 | ||
| 534 | * On sourceforge, make the source package the default for all but | 557 | * On sourceforge, make the source package the default for all but |
| 535 | Windows, and make the 64-bit msvc build the default for Windows. | 558 | Windows, and make the 64-bit msvc build the default for Windows. |