Commit 88c3d556d552a94aa42eaa2fa43667952e123dc8
1 parent
e782d5e9
Spell check
Showing
4 changed files
with
7 additions
and
6 deletions
README-maintainer
| @@ -93,7 +93,7 @@ CODING RULES | @@ -93,7 +93,7 @@ CODING RULES | ||
| 93 | first at least once, thereby ensuring that it explicitly includes | 93 | first at least once, thereby ensuring that it explicitly includes |
| 94 | all the headers it needs, which in turn alleviates lots of header | 94 | all the headers it needs, which in turn alleviates lots of header |
| 95 | ordering problems. The blank line ensures that formatters don't | 95 | ordering problems. The blank line ensures that formatters don't |
| 96 | - messt his up by resorting the headers. | 96 | + mess this up by resorting the headers. |
| 97 | 97 | ||
| 98 | * Avoid atoi. Use QUtil::string_to_int instead. It does | 98 | * Avoid atoi. Use QUtil::string_to_int instead. It does |
| 99 | overflow/underflow checking. | 99 | overflow/underflow checking. |
TODO
| @@ -344,7 +344,7 @@ PointerHolder to std::shared_ptr | @@ -344,7 +344,7 @@ PointerHolder to std::shared_ptr | ||
| 344 | ================================ | 344 | ================================ |
| 345 | 345 | ||
| 346 | Once all deprecation warnings are cleared up (changing getPointer() to | 346 | Once all deprecation warnings are cleared up (changing getPointer() to |
| 347 | -get() and getRefcout() to use_count()), the only real issues are that | 347 | +get() and getRefcount() to use_count()), the only real issues are that |
| 348 | implicit assignment of a pointer to a shared_ptr doesn't work while it | 348 | implicit assignment of a pointer to a shared_ptr doesn't work while it |
| 349 | does for PointerHolder and containers are different. Using auto takes | 349 | does for PointerHolder and containers are different. Using auto takes |
| 350 | care of containers. | 350 | care of containers. |
| @@ -402,7 +402,7 @@ Strategy: | @@ -402,7 +402,7 @@ Strategy: | ||
| 402 | * Replace each public API one at a time | 402 | * Replace each public API one at a time |
| 403 | * Replace remaining internal uses; sometimes unique_ptr may be good, | 403 | * Replace remaining internal uses; sometimes unique_ptr may be good, |
| 404 | particularly for temporary strings that are deleted in the same | 404 | particularly for temporary strings that are deleted in the same |
| 405 | - scope and Members for non-copiable classes | 405 | + scope and Members for non-copyable classes |
| 406 | * std::shared_ptr<Members> m can be replaced with | 406 | * std::shared_ptr<Members> m can be replaced with |
| 407 | std::shared_ptr<Members> m_ph and Members* m if performance is critical | 407 | std::shared_ptr<Members> m_ph and Members* m if performance is critical |
| 408 | * Remove #include <PointerHolder.hh> from all headers | 408 | * Remove #include <PointerHolder.hh> from all headers |
cSpell.json
| @@ -63,7 +63,6 @@ | @@ -63,7 +63,6 @@ | ||
| 63 | "coldwind", | 63 | "coldwind", |
| 64 | "colorspace", | 64 | "colorspace", |
| 65 | "conftest", | 65 | "conftest", |
| 66 | - "copiable", | ||
| 67 | "cout", | 66 | "cout", |
| 68 | "cphe", | 67 | "cphe", |
| 69 | "cppflags", | 68 | "cppflags", |
| @@ -129,7 +128,6 @@ | @@ -129,7 +128,6 @@ | ||
| 129 | "fuzzer", | 128 | "fuzzer", |
| 130 | "fuzzers", | 129 | "fuzzers", |
| 131 | "fvisibility", | 130 | "fvisibility", |
| 132 | - "iostream", | ||
| 133 | "gajic", | 131 | "gajic", |
| 134 | "gajić", | 132 | "gajić", |
| 135 | "gcurl", | 133 | "gcurl", |
| @@ -163,6 +161,7 @@ | @@ -163,6 +161,7 @@ | ||
| 163 | "infilename", | 161 | "infilename", |
| 164 | "inheritsresources", | 162 | "inheritsresources", |
| 165 | "inpdf", | 163 | "inpdf", |
| 164 | + "iostream", | ||
| 166 | "ioutfilename", | 165 | "ioutfilename", |
| 167 | "irdp", | 166 | "irdp", |
| 168 | "ischeckbox", | 167 | "ischeckbox", |
| @@ -305,6 +304,7 @@ | @@ -305,6 +304,7 @@ | ||
| 305 | "pldh", | 304 | "pldh", |
| 306 | "pluggable", | 305 | "pluggable", |
| 307 | "pngify", | 306 | "pngify", |
| 307 | + "pointerholder", | ||
| 308 | "poppler", | 308 | "poppler", |
| 309 | "prebuild", | 309 | "prebuild", |
| 310 | "precheck", | 310 | "precheck", |
| @@ -373,6 +373,7 @@ | @@ -373,6 +373,7 @@ | ||
| 373 | "rcon", | 373 | "rcon", |
| 374 | "rdpp", | 374 | "rdpp", |
| 375 | "rdquo", | 375 | "rdquo", |
| 376 | + "refcount", | ||
| 376 | "resave", | 377 | "resave", |
| 377 | "retargeted", | 378 | "retargeted", |
| 378 | "rfont", | 379 | "rfont", |
libtests/pointer_holder.cc
| @@ -106,7 +106,7 @@ int main(int argc, char* argv[]) | @@ -106,7 +106,7 @@ int main(int argc, char* argv[]) | ||
| 106 | callHelloWithGet(ol1.front()); | 106 | callHelloWithGet(ol1.front()); |
| 107 | ol1.pop_front(); | 107 | ol1.pop_front(); |
| 108 | std::cout << "array" << std::endl; | 108 | std::cout << "array" << std::endl; |
| 109 | - PointerHolder<Object> oarr1_ph(true, new Object[2]); | 109 | + PointerHolder<Object> o_arr1_ph(true, new Object[2]); |
| 110 | std::cout << "goodbye" << std::endl; | 110 | std::cout << "goodbye" << std::endl; |
| 111 | return 0; | 111 | return 0; |
| 112 | } | 112 | } |