Fix field traversal in `AcroForm::transformAnnotations`: replace iterator with `front`/`pop_front`

Fixes #1620

Fix field traversal in `AcroForm::transformAnnotations`: replace iterator with `front`/`pop_front`
Fixes #1620
m-holger
1 parent faab5274
Showing 1 changed file with 2 additions and 2 deletions
libqpdf/QPDFAcroFormDocumentHelper.cc
@@ -955,8 +955,8 @@ AcroForm::transformAnnotations(
     auto traverse_field = [&](QPDFObjectHandle& top_field) -> void {
         std::deque<Dictionary> queue({top_field});
         QPDFObjGen::set seen;
-        for (auto it = queue.begin(); it != queue.end(); ++it) {
-            auto& obj = *it;
+        for (; !queue.empty(); queue.pop_front()) {
+            auto& obj = queue.front();
             if (seen.add(obj)) {
                 Dictionary parent = obj["/Parent"];
                 if (parent.indirect()) {