set page labels: detect start page < 1 (fixes #939)

Jay Berkenbilt
1 parent 072623d6
Showing 2 changed files with 5 additions and 2 deletions
libqpdf/QPDFJob_config.cc
qpdf/qtest/page-labels.test
@@ -1139,6 +1139,9 @@ QPDFJob::Config::setPageLabels(const std::vector&lt;std::string&gt;&amp; specs)
         }
  
         auto start_num = match[3].matched ? QUtil::string_to_int(match[3].str().c_str()) : 1;
+        if (start_num < 1) {
+            usage("starting page number must be >= 1");
+        }
         auto prefix = match[4].matched ? match[4].str() : "";
         // We can't check ordering until we know how many pages there are, so that is delayed until
         // near the end.
@@ -33,8 +33,8 @@ $td-&gt;runtest(&quot;no page labels&quot;,
 my @errors = (
     ["quack", ".*page label spec must be.*"],
     ["5:r 10:D", ".*the first page .*must start with page 1.*"],
-    ["1:r 10:D 31:A",
-     ".*page 31 is more than the total number of pages \\(30\\).*"],
+    ["1:r 10:D 31:A", ".*page 31 is more than the total number of pages \\(30\\).*"],
+    ["1:r/0", ".*starting page number must be >= 1.*"],
 );
 $n_tests += scalar(@errors);