Commit 794b649e5b15b193c8682b5a7e67fda3bb719b96
1 parent
4edfe1f4
Update TODO and ChangeLog. Fixes #166, #83
Showing
2 changed files
with
18 additions
and
8 deletions
ChangeLog
| 1 | +2017-12-25 Jay Berkenbilt <ejb@ql.org> | |
| 2 | + | |
| 3 | + * Implement remaining PNG filters for decode. Prior versions could | |
| 4 | + decode only the "up" filter. Now all PNG filters (sub, up, | |
| 5 | + average, Paeth, optimal) are supported for decoding. Thanks to | |
| 6 | + Tobias Hoffmann for providing a test PDF file that has images with | |
| 7 | + all PNG filters along with different numbers of bits per sample | |
| 8 | + and samples per pixel, and thanks to Casey Rojas for providing | |
| 9 | + implementations of the remaining PNG filters. | |
| 10 | + | |
| 11 | + The implementation of the remaining PNG filters changed the | |
| 12 | + interface to the private Pl_PNGFilter class, but this class's | |
| 13 | + header file is not in the installation, and there is no public | |
| 14 | + interface to the class. Within the library, the class is never | |
| 15 | + allocated on the stack; it is only ever dynamically allocated. As | |
| 16 | + such, this does not actually break binary compatibility of the | |
| 17 | + library. | |
| 18 | + | |
| 1 | 19 | 2017-09-15 Jay Berkenbilt <ejb@ql.org> |
| 2 | 20 | |
| 3 | 21 | * 7.0.0: release | ... | ... |
TODO
| ... | ... | @@ -53,8 +53,6 @@ I find it useful to make reference to them in this list |
| 53 | 53 | filtering doesn't ever try to do this. QPDFWriter should be checked |
| 54 | 54 | carefully too. See also bugs/private/from-email-663916/ |
| 55 | 55 | |
| 56 | - * Implement remaining PNG filters. See https://github.com/qpdf/qpdf/pull/166 | |
| 57 | - | |
| 58 | 56 | * Form flattening: ~/tmp/qtmp/form-flattening-email/. Distill this |
| 59 | 57 | into notes along with stuff in qpdf email box. |
| 60 | 58 | |
| ... | ... | @@ -236,12 +234,6 @@ Index: QPDFWriter.cc |
| 236 | 234 | viewing software silently ignores objects of this type, so this is |
| 237 | 235 | probably not a big deal. |
| 238 | 236 | |
| 239 | - * Pl_PNGFilter is only partially implemented. If we ever decoded | |
| 240 | - images, we'd have to finish implementing it along with the other | |
| 241 | - filter decode parameters and types. For just handling xref | |
| 242 | - streams, there's really no need as it wouldn't make sense to use | |
| 243 | - any kind of predictor other than 12 (PNG UP filter). | |
| 244 | - | |
| 245 | 237 | * If we ever want to have check mode check the integrity of the free |
| 246 | 238 | list, this can be done by looking at the code from prior to the |
| 247 | 239 | object stream support of 4/5/2008. It's in an if (0) block and | ... | ... |