Add check for shared appearance stream in QPDFFormFieldObjectHelper::generateTextAppearance

Ensure an appearance stream is not shared before generating text appearances, improving error handling and data integrity.

Add check for shared appearance stream in QPDFFormFieldObjectHelper::generateTextAppearance
Ensure an appearance stream is not shared before generating text appearances, improving error handling and data integrity.
m-holger
1 parent ca80db6f
Showing 4 changed files with 8 additions and 2 deletions
fuzz/CMakeLists.txt
fuzz/qpdf_extra/433311400.fuzz
fuzz/qtest/fuzz.test
libqpdf/QPDFFormFieldObjectHelper.cc
@@ -158,6 +158,7 @@ set(CORPUS_OTHER
   398060137.fuzz
   409905355.fuzz
   411312393.fuzz
+  433311400.fuzz
   5109284021272576.fuzz
 )
  
@@ -11,7 +11,7 @@ my $td = new TestDriver(&#39;fuzz&#39;);
  
 my $qpdf_corpus = $ENV{'QPDF_FUZZ_CORPUS'} || die "must set QPDF_FUZZ_CORPUS";
  
-my $n_qpdf_files = 96;       # increment when adding new files
+my $n_qpdf_files = 97;       # increment when adding new files
  
 my @fuzzers = (
     ['ascii85' => 1],
@@ -773,6 +773,12 @@ QPDFFormFieldObjectHelper::generateTextAppearance(QPDFAnnotationObjectHelper&amp; ao
         aoh.getObjectHandle().warnIfPossible("unable to get normal appearance stream for update");
         return;
     }
+
+    if (AS.getObj().use_count() > 4) {
+        aoh.getObjectHandle().warnIfPossible(
+            "unable to generate text appearance from shared appearance stream for update");
+        return;
+    }
     QPDFObjectHandle bbox_obj = AS.getDict().getKey("/BBox");
     if (!bbox_obj.isRectangle()) {
         aoh.getObjectHandle().warnIfPossible("unable to get appearance stream bounding box");
@@ -831,7 +837,6 @@ QPDFFormFieldObjectHelper::generateTextAppearance(QPDFAnnotationObjectHelper&amp; ao
     for (size_t i = 0; i < opt.size(); ++i) {
         opt.at(i) = (*encoder)(opt.at(i), '?');
     }
-
     AS.addTokenFilter(
         std::shared_ptr<QPDFObjectHandle::TokenFilter>(new ValueSetter(DA, V, opt, tf, bbox)));
 }