Fix issues with abi-perf-test

Jay Berkenbilt
1 parent 2e35ead5
Showing 2 changed files with 16 additions and 9 deletions
README-maintainer
abi-perf-test
@@ -353,7 +353,7 @@ RELEASE PREPARATION
 * Test for performance and binary compatibility:
-  ./abi-perf-test release-<old> @
+  ./abi-perf-test v<old> @
   Prefix with SKIP_PERF=1 to skip performance test.
   Prefix with SKIP_TESTS=1 to skip test suite run.
@@ -89,6 +89,7 @@ $source/check_abi compare --old-lib $work/old/libqpdf.so.*.* \
   --new-lib build/libqpdf/libqpdf.so \
   --old-sizes $work/old/sizes --new-sizes $work/new/sizes
+test_warn=0
 if [ "$SKIP_TESTS" != "1" ]; then
     # Switch back to the previous release and run tests. There may be
     # some failures based on functionality change. We are looking for
@@ -97,14 +98,7 @@ if [ &quot;$SKIP_TESTS&quot; != &quot;1&quot; ]; then
     set +e
     (cd build; ctest --verbose)
     if [ $? != 0 ]; then
-        cat <<EOF
-
-**********************************************************************
-There were some test failures; inspect to determine whether they are
-ABI-related.
-**********************************************************************
-
-EOF
+        test_warn=1
     fi
     set -e
 fi
@@ -121,3 +115,16 @@ if [ &quot;$SKIP_PERF&quot; != &quot;1&quot; ]; then
     $source/performance_check --dir $source/../performance-test-files | \
         tee -a $work/perf
 fi
+
+if [ $test_warn = 1 ]; then
+    cat <<EOF
+
+**********************************************************************
+There were some test failures; inspect to determine whether they are
+ABI-related.
+
+Check test results in $work/qpdf/build
+**********************************************************************
+
+EOF
+fi