Commit 5f59c32f876556a031dd2536b5c7f0fb0b58968d
1 parent
a167ce81
Add a few minor enhancements to recent work
Test coverage case for new newStream method Expose decimal_places argument for double-based newReal All enhancements suggested by Tobias.
Showing
4 changed files
with
6 additions
and
5 deletions
examples/pdf-double-page-size.cc
| ... | ... | @@ -36,8 +36,7 @@ static void doubleBoxSize(QPDFObjectHandle& page, char const* box_name) |
| 36 | 36 | { |
| 37 | 37 | doubled.push_back( |
| 38 | 38 | QPDFObjectHandle::newReal( |
| 39 | - QUtil::double_to_string( | |
| 40 | - box.getArrayItem(i).getNumericValue() * 2.0, 2))); | |
| 39 | + box.getArrayItem(i).getNumericValue() * 2.0, 2)); | |
| 41 | 40 | } |
| 42 | 41 | page.replaceKey(box_name, QPDFObjectHandle::newArray(doubled)); |
| 43 | 42 | } | ... | ... |
include/qpdf/QPDFObjectHandle.hh
| ... | ... | @@ -102,7 +102,7 @@ class QPDFObjectHandle |
| 102 | 102 | QPDF_DLL |
| 103 | 103 | static QPDFObjectHandle newReal(std::string const& value); |
| 104 | 104 | QPDF_DLL |
| 105 | - static QPDFObjectHandle newReal(double value); | |
| 105 | + static QPDFObjectHandle newReal(double value, int decimal_places = 0); | |
| 106 | 106 | QPDF_DLL |
| 107 | 107 | static QPDFObjectHandle newName(std::string const& name); |
| 108 | 108 | QPDF_DLL | ... | ... |
libqpdf/QPDFObjectHandle.cc
| ... | ... | @@ -604,9 +604,9 @@ QPDFObjectHandle::newReal(std::string const& value) |
| 604 | 604 | } |
| 605 | 605 | |
| 606 | 606 | QPDFObjectHandle |
| 607 | -QPDFObjectHandle::newReal(double value) | |
| 607 | +QPDFObjectHandle::newReal(double value, int decimal_places) | |
| 608 | 608 | { |
| 609 | - return QPDFObjectHandle(new QPDF_Real(value)); | |
| 609 | + return QPDFObjectHandle(new QPDF_Real(value, decimal_places)); | |
| 610 | 610 | } |
| 611 | 611 | |
| 612 | 612 | QPDFObjectHandle |
| ... | ... | @@ -683,6 +683,7 @@ QPDFObjectHandle::newStream(QPDF* qpdf, PointerHolder<Buffer> data) |
| 683 | 683 | QPDFObjectHandle |
| 684 | 684 | QPDFObjectHandle::newStream(QPDF* qpdf, std::string const& data) |
| 685 | 685 | { |
| 686 | + QTC::TC("qpdf", "QPDFObjectHandle newStream with string"); | |
| 686 | 687 | PointerHolder<Buffer> b = new Buffer(data.length()); |
| 687 | 688 | unsigned char* bp = b->getBuffer(); |
| 688 | 689 | memcpy(bp, (char*)data.c_str(), data.length()); | ... | ... |
qpdf/qpdf.testcov