Commit 59b775104a4b80aba836163c1530e4117c3ad4bd
1 parent
01969c78
TODO note
Showing
1 changed file
with
8 additions
and
1 deletions
TODO
| @@ -6,8 +6,15 @@ Next | @@ -6,8 +6,15 @@ Next | ||
| 6 | be like QPDFObjectHandle::parse: `auto oh = "<< /a (b) >>"_qpdf;` | 6 | be like QPDFObjectHandle::parse: `auto oh = "<< /a (b) >>"_qpdf;` |
| 7 | * Add QPDF_MAJOR_VERSION, QPDF_MINOR_VERSION to some header, possibly | 7 | * Add QPDF_MAJOR_VERSION, QPDF_MINOR_VERSION to some header, possibly |
| 8 | dll.h since this is everywhere that there's API | 8 | dll.h since this is everywhere that there's API |
| 9 | + | ||
| 9 | * Take a fresh look at PointerHolder with a good plan for being able | 10 | * Take a fresh look at PointerHolder with a good plan for being able |
| 10 | - to have developers phase it in using macros or something. | 11 | + to have developers phase it in using macros or something. Decide |
| 12 | + about shared_ptr vs unique_ptr for each time make_shared_cstr is | ||
| 13 | + called. For non-copiable classes, we can use unique_ptr instead of | ||
| 14 | + shared_ptr as a replacement for PointerHolder. For performance | ||
| 15 | + critical cases, we could potentially have a real pointer and a | ||
| 16 | + shared pointer where the shared pointer's job is to clean up but we | ||
| 17 | + use the real pointer for regular access. | ||
| 11 | 18 | ||
| 12 | Consider in the context of #593, possibly with a different | 19 | Consider in the context of #593, possibly with a different |
| 13 | implementation | 20 | implementation |