Shallow copy arrays without removing sparseness

Jay Berkenbilt
1 parent bf7c6a80
Showing 3 changed files with 12 additions and 1 deletions
libqpdf/QPDFObjectHandle.cc
libqpdf/QPDF_Array.cc
libqpdf/qpdf/QPDF_Array.hh
@@ -2340,7 +2340,10 @@ QPDFObjectHandle::shallowCopy()
     if (isArray())
     {
 	QTC::TC("qpdf", "QPDFObjectHandle shallow copy array");
-	new_obj = newArray(getArrayAsVector());
+        // No newArray for shallow copying the sparse array
+        QPDF_Array* arr = dynamic_cast<QPDF_Array*>(m->obj.getPointer());
+        new_obj = QPDFObjectHandle(
+            new QPDF_Array(arr->getElementsForShallowCopy()));
     }
     else if (isDictionary())
     {
@@ -136,3 +136,9 @@ QPDF_Array::eraseItem(int at)
 {
     this->elements.erase(QIntC::to_size(at));
 }
+
+SparseOHArray const&
+QPDF_Array::getElementsForShallowCopy() const
+{
+    return this->elements;
+}
@@ -28,6 +28,8 @@ class QPDF_Array: public QPDFObject
     void appendItem(QPDFObjectHandle const& item);
     void eraseItem(int at);
  
+    SparseOHArray const& getElementsForShallowCopy() const;
+
   protected:
     virtual void releaseResolved();