Convert some cases of logic_error to runtime_error

There were a few cases that could be caused by invalid input rather than bugs in the code which were throwing logic_error instead of runtime_error.

Convert some cases of logic_error to runtime_error
There were a few cases that could be caused by invalid input rather than bugs in the code which were throwing logic_error instead of runtime_error.
Jay Berkenbilt
1 parent 201e8798
Showing 2 changed files with 6 additions and 6 deletions
libqpdf/QPDFObjectHandle.cc
libqpdf/QPDF_pages.cc
@@ -2515,7 +2515,7 @@ QPDFObjectHandle::warnIfPossible(std::string const&amp; warning,
     }
     else if (throw_if_no_description)
     {
-        throw std::logic_error(warning);
+        throw std::runtime_error(warning);
     }
 }
  
@@ -2530,9 +2530,9 @@ QPDFObjectHandle::assertType(char const* type_name, bool istype)
 {
     if (! istype)
     {
-	throw std::logic_error(std::string("operation for ") + type_name +
-			       " attempted on object of type " +
-                               getTypeName());
+	throw std::runtime_error(std::string("operation for ") + type_name +
+                                 " attempted on object of type " +
+                                 getTypeName());
     }
 }
  
@@ -2670,7 +2670,7 @@ QPDFObjectHandle::assertPageObject()
 {
     if (! isPageObject())
     {
-	throw std::logic_error("page operation called on non-Page object");
+	throw std::runtime_error("page operation called on non-Page object");
     }
 }
  
@@ -166,7 +166,7 @@ QPDF::flattenPagesTree()
     // /Count has not changed
     if (pages.getKey("/Count").getUIntValue() != len)
     {
-        throw std::logic_error("/Count is wrong after flattening pages tree");
+        throw std::runtime_error("/Count is wrong after flattening pages tree");
     }
 }