Copy subdictionaries when removing resources (fixes #276)

When removing unreferenced resources, the code was copying the overall resource dictionaries but not the subdictionaries being modified. This was a "typo" in the code -- the comment clearly stated the need to do this, but the code replaced the dictionary with itself rather than with a shallow copy of itself.

Copy subdictionaries when removing resources (fixes #276)
When removing unreferenced resources, the code was copying the overall resource dictionaries but not the subdictionaries being modified. This was a "typo" in the code -- the comment clearly stated the need to do this, but the code replaced the dictionary with itself rather than with a shallow copy of itself.
Jay Berkenbilt
1 parent aad2b108
Showing 1 changed file with 1 additions and 0 deletions
libqpdf/QPDFPageObjectHelper.cc
@@ -156,6 +156,7 @@ QPDFPageObjectHelper::removeUnreferencedResources()
         {
             continue;
         }
+        dict = dict.shallowCopy();
         resources.replaceKey(*d_iter, dict);
         std::set<std::string> keys = dict.getKeys();
         for (std::set<std::string>::iterator k_iter = keys.begin();