In QPDF::interpretCF refactor crypt filter lookup for clarity and efficiency

Replace `count` method with iterator-based lookup to improve readability and reduce redundancy. Simplify conditional logic for determining the encryption filter, ensuring the default case remains clear.

In QPDF::interpretCF refactor crypt filter lookup for clarity and efficiency
Replace `count` method with iterator-based lookup to improve readability and reduce redundancy. Simplify conditional logic for determining the encryption filter, ensuring the default case remains clear.
m-holger
1 parent 6a599276
Showing 2 changed files with 9 additions and 13 deletions
libqpdf/JSON.cc
libqpdf/QPDF_encryption.cc
@@ -494,11 +494,7 @@ JSON::checkSchemaInternal(
         auto pattern_schema = sch_dict->members[pattern_key].m->value.get();
         for (auto const& [key, val]: this_dict->members) {
             checkSchemaInternal(
-                val.m->value.get(),
-                pattern_schema,
-                flags,
-                errors,
-                prefix + "." + key);
+                val.m->value.get(), pattern_schema, flags, errors, prefix + "." + key);
         }
     } else if (sch_dict) {
         for (auto& [key, val]: sch_dict->members) {
@@ -702,17 +702,17 @@ QPDF::interpretCF(std::shared_ptr&lt;EncryptionParameters&gt; encp, QPDFObjectHandle c
 {
     if (cf.isName()) {
         std::string filter = cf.getName();
-        if (encp->crypt_filters.count(filter) != 0) {
-            return encp->crypt_filters[filter];
-        } else if (filter == "/Identity") {
+        auto it = encp->crypt_filters.find(filter);
+        if (it != encp->crypt_filters.end()) {
+            return it->second;
+        }
+        if (filter == "/Identity") {
             return e_none;
-        } else {
-            return e_unknown;
         }
-    } else {
-        // Default: /Identity
-        return e_none;
+        return e_unknown;
     }
+    // Default: /Identity
+    return e_none;
 }
 void