Fix password handling in QPDFJob to allow multiple specifications and add tests

Fixes #1659

Fix password handling in QPDFJob to allow multiple specifications and add tests
Fixes #1659
m-holger
1 parent 5dbcd9c9
Showing 4 changed files with 23 additions and 3 deletions
libqpdf/QPDFJob.cc
libqpdf/qpdf/QPDFJob_private.hh
manual/release-notes.rst
qpdf/qtest/arg-parsing.test
@@ -2505,9 +2505,13 @@ void
 QPDFJob::Selection::password(std::string password)
 {
     auto& in = input();
-    if (!in.password.empty()) {
+    if (password_provided) {
         usage("--password already specified for this file");
     }
+    if (!(in.password.empty() || in.password == password)) {
+        usage("different --password already specified for this file");
+    }
+    password_provided = true;
     in.password = password;
 }
@@ -29,6 +29,7 @@ struct QPDFJob::Selection
     std::pair<const std::string, QPDFJob::Input>* in_entry{nullptr};
     std::string range; // An empty range means all pages.
     std::vector<int> selected_pages;
+    bool password_provided{false};
 };
 // A single input PDF.
@@ -13,8 +13,13 @@ more detail.
 .. x.y.z: not yet released
-
 12.3.2: not yet released
+  - Bug fixes
+
+    - Fix bug introduced in 12.3.0. If the :qpdf:ref:`--password` was specified
+      for the same file multiple times a usage error was thrown. Specifying
+      the the password multiple times is common within the :qpdf:ref:`--pages`
+      option when using the QPDFJob interface.
 12.3.1: January 19, 2026
   - Bug fixes
@@ -15,7 +15,7 @@ cleanup();
 my $td = new TestDriver('arg-parsing');
-my $n_tests = 33;
+my $n_tests = 35;
 $td->runtest("required argument",
              {$td->COMMAND => "qpdf --password minimal.pdf"},
@@ -88,6 +88,16 @@ $td-&gt;runtest(&quot;duplicated pages password&quot;,
              {$td->REGEXP => ".*password already specified.*",
                   $td->EXIT_STATUS => 2},
              $td->NORMALIZE_NEWLINES);
+$td->runtest("inconsistent pages passwords",
+             {$td->COMMAND => "qpdf --pages . --password=z --range=1 . --password=y --range=2 --"},
+             {$td->REGEXP => ".*different --password already specified.*",
+                  $td->EXIT_STATUS => 2},
+             $td->NORMALIZE_NEWLINES);
+$td->runtest("consistent pages passwords",
+             {$td->COMMAND => "qpdf --pages . --password=z --range=1 . --password=z --range=2 --"},
+             {$td->REGEXP => ".*an input file name is required.*",
+                  $td->EXIT_STATUS => 2},
+             $td->NORMALIZE_NEWLINES);
 $td->runtest("v1-only objects json-key",
              {$td->COMMAND => "qpdf --json=2 --json-key=objects minimal.pdf"},
              {$td->REGEXP => ".*\"objects\" and \"objectinfo\" are " .