Add `Buffer::view()` method and update unit tests

Implement `Buffer::view()` to provide a read-only view of the buffer content. Update unit tests to validate `view()` behavior alongside `move()`. Include necessary `#include <string_view>` for functionality.

Add `Buffer::view()` method and update unit tests
Implement `Buffer::view()` to provide a read-only view of the buffer content. Update unit tests to validate `view()` behavior alongside `move()`. Include necessary `#include <string_view>` for functionality.
m-holger
1 parent 6df06185
Showing 3 changed files with 17 additions and 1 deletions
include/qpdf/Buffer.hh
libqpdf/Buffer.cc
libtests/buffer.cc
@@ -25,6 +25,7 @@
 #include <cstddef>
 #include <memory>
 #include <string>
+#include <string_view>
  
 class Buffer
 {
@@ -71,6 +72,10 @@ class Buffer
     QPDF_DLL
     std::string move();
  
+    // Return a string_view to the data.
+    QPDF_DLL
+    std::string_view view() const;
+
   private:
     class Members;
  
@@ -108,3 +108,12 @@ Buffer::move()
     }
     return {m->buf, m->size};
 }
+
+std::string_view
+Buffer::view() const
+{
+    if (!m->buf) {
+        return {};
+    }
+    return {m->buf, m->size};
+}
@@ -35,11 +35,13 @@ main()
     assert(bc2p[0] == 'R');
     assert(bc2p[1] == 'W');
  
-    // Test move method
+    // Test move and view method
+    assert(bc1.view() == "RW");
     auto s1 = bc1.move();
     assert(bc1.getBuffer() == nullptr);
     assert(bc1.getSize() == 0);
     assert(s1 == "RW");
+    assert(bc1.view().empty());
  
     // Test Buffer(std:string&&)
     Buffer bc3("QW");