Remove QPDF::copyForeignObject with unused parameter

Jay Berkenbilt
1 parent c6cfd645
Showing 4 changed files with 4 additions and 13 deletions
ChangeLog
TODO
include/qpdf/QPDF.hh
libqpdf/QPDF.cc
 2019-06-21  Jay Berkenbilt  <ejb@ql.org>
  
+	* Source-level incompatibility: remove the version
+	QPDF::copyForeignObject with an unused boolean parameter. If you
+	were, for some reason, calling this, just take the parameter away.
+
 	* Source-level incompatibility: rename QUtil::strcasecmp to
 	QUtil::str_compare_nocase. This is a non-compatible change, but
 	QUtil::strcasecmp is hardly the most important part of qpdf's API.
 Next ABI
 ========
  
- * Get rid of the version of QPDF::copyForeignObject with the bool
-   unused parameter.
-
  * Remove version of QPDFTokenizer::expectInlineImage with no
    arguments.
  
@@ -934,9 +934,6 @@ class QPDF
 	QPDFObjectHandle& stream_dict, bool is_attachment_stream,
 	std::vector<PointerHolder<Pipeline> >& heap);
  
-    // Unused copyForeignObject -- remove at next ABI change
-    QPDFObjectHandle copyForeignObject(
-        QPDFObjectHandle foreign, bool unused);
     // Methods to support object copying
     void reserveObjects(QPDFObjectHandle foreign, ObjCopier& obj_copier,
                         bool top);
@@ -2142,13 +2142,6 @@ QPDF::replaceReserved(QPDFObjectHandle reserved,
 }
  
 QPDFObjectHandle
-QPDF::copyForeignObject(QPDFObjectHandle foreign, bool)
-{
-    // This method will be removed next time the ABI is changed.
-    return copyForeignObject(foreign);
-}
-
-QPDFObjectHandle
 QPDF::copyForeignObject(QPDFObjectHandle foreign)
 {
     // Do not preclude use of copyForeignObject on page objects. It is