Refactor `Integer` constructor: replace manual comparisons with `std::cmp_greate…

…r` for cleaner and more concise overflow checks.

Refactor `Integer` constructor: replace manual comparisons with `std::cmp_greate…
…r` for cleaner and more concise overflow checks.
m-holger
1 parent 753b86f9
Showing 1 changed file with 4 additions and 4 deletions
libqpdf/qpdf/QPDFObjectHandle_private.hh
@@ -305,10 +305,10 @@ namespace qpdf
         explicit Integer(std::integral auto value) :
             Integer(static_cast<long long>(value))
         {
-            if constexpr (
-                std::numeric_limits<decltype(value)>::max() >
-                std::numeric_limits<long long>::max()) {
-                if (value > std::numeric_limits<long long>::max()) {
+            if constexpr (std::cmp_greater(
+                              std::numeric_limits<decltype(value)>::max(),
+                              std::numeric_limits<long long>::max())) {
+                if (std::cmp_greater(value, std::numeric_limits<long long>::max())) {
                     throw std::overflow_error("overflow constructing Integer");
                 }
             }