Commit 06c5bac96c9d18d8336a65e2ad6f8283530514c2

Authored by Jay Berkenbilt
1 parent f8306913

Clarify TODO note about crypt filters

Showing 1 changed file with 8 additions and 7 deletions
@@ -79,13 +79,14 @@ Index: QPDFWriter.cc @@ -79,13 +79,14 @@ Index: QPDFWriter.cc
79 * The description of Crypt filters is unclear with respect to how to 79 * The description of Crypt filters is unclear with respect to how to
80 use them to override /StmF for specific streams. I'm not sure 80 use them to override /StmF for specific streams. I'm not sure
81 whether qpdf will do the right thing for any specific individual 81 whether qpdf will do the right thing for any specific individual
82 - streams that might have crypt filters. The specification seems to  
83 - imply that only embedded file streams and metadata streams can have  
84 - crypt filters, and there are already special cases in the code to  
85 - handle those. Most likely, it won't be a problem, but someday  
86 - someone may find a file that qpdf doesn't work on because of crypt  
87 - filters. There is an example in the spec of using a crypt filter  
88 - on a metadata stream. 82 + streams that might have crypt filters, but I believe it does based
  83 + on my testing of a limited subset. The specification seems to imply
  84 + that only embedded file streams and metadata streams can have crypt
  85 + filters, and there are already special cases in the code to handle
  86 + those. Most likely, it won't be a problem, but someday someone may
  87 + find a file that qpdf doesn't work on because of crypt filters.
  88 + There is an example in the spec of using a crypt filter on a
  89 + metadata stream.
89 90
90 For now, we notice /Crypt filters and decode parameters consistent 91 For now, we notice /Crypt filters and decode parameters consistent
91 with the example in the PDF specification, and the right thing 92 with the example in the PDF specification, and the right thing